Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105071: add PyUnstable_Exc_PrepReraiseStar to expose except* implementation in the unstable API#105072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

iritkatriel
Copy link
Member

@iritkatrieliritkatriel commentedMay 29, 2023•
edited by github-actionsbot
Loading

I did not rename the internal function, but rather added an API function that calls it. This is because the internal function can make more assumptions about the input than an API function (so the API function raises exceptions on things that the internal function just asserts).

Fixes#105071.

CC@da-woods .

📚 Documentation preview 📚:https://cpython-previews--105072.org.readthedocs.build/

zooba and gpshead reacted with thumbs up emoji
Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Doc formatting nits. Otherwise: lgtm, as far as I can see.

iritkatriel reacted with thumbs up emoji
iritkatrieland others added2 commitsMay 30, 2023 11:12
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Copy link
Member

@encukouencukou left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, thanks!

@iritkatrieliritkatriel added the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 30, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@iritkatriel for commit784b102 🤖

If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-refleak-buildbotsTest PR w/ refleak buildbots; report in status section labelMay 30, 2023
@iritkatrieliritkatriel added needs backport to 3.12only security fixes topic-C-API interpreter-core(Objects, Python, Grammar, and Parser dirs) and removed topic-C-API labelsMay 30, 2023
@iritkatrieliritkatriel merged commitb7aadb4 intopython:mainMay 30, 2023
@miss-islington
Copy link
Contributor

Thanks@iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@iritkatriel, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker b7aadb4583b040ddc8564896b91f4e5e571c82d6 3.12

iritkatriel added a commit to iritkatriel/cpython that referenced this pull requestMay 30, 2023
…except* implementation in the unstable API (pythonGH-105072)(cherry picked from commitb7aadb4)Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

GH-105095 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 30, 2023
@bedevere-bot
Copy link

GH-105095 is a backport of this pull request to the3.12 branch.

iritkatriel added a commit that referenced this pull requestMay 30, 2023
…* implementation in the unstable API (GH-105072) (#105095)(cherry picked from commitb7aadb4)
@iritkatrieliritkatriel deleted the PyUnstable_Exc_PrepReraiseStar branchJuly 25, 2023 18:05
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland left review comments

@encukouencukouencukou approved these changes

Assignees

@iritkatrieliritkatriel

Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PyUnstable_Exc_PrepReraiseStar
5 participants
@iritkatriel@bedevere-bot@miss-islington@encukou@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp