Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103646: Remove --include-pip-user from default APPX package build#105064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 1 commit intopython:mainfromzooba:gh-103646
May 29, 2023

Conversation

zooba
Copy link
Member

@zoobazooba commentedMay 29, 2023•
edited by bedevere-bot
Loading

Copy link
Member

@pfmoorepfmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is it not possible to completely remove the "pip-user" option? As far as I can see, it's only used inget_pip_layout inPC\layout\support\pip.py. Having the option present but never used seems like a potential source of confusion.

@zooba
Copy link
MemberAuthor

zooba commentedMay 29, 2023•
edited
Loading

Deprecating and removing a command line option is a bigger change than just changing a preset, since the presets are deliberately unspecified.

I doubt anyone is actually using it, but I see no reason to find out by simply removing it. There are potentially useful scenarios that might be using it where they wouldn't be covered by the unwritable-Lib fallback (I know of one such scenario, though I don't know that they're actively using this option).

pfmoore reacted with thumbs up emoji

@zoobazooba merged commit6da7015 intopython:mainMay 29, 2023
@miss-islington
Copy link
Contributor

Thanks@zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 29, 2023
…build (pythonGH-105064)(cherry picked from commit6da7015)Co-authored-by: Steve Dower <steve.dower@python.org>
@bedevere-bot
Copy link

GH-105065 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 29, 2023
@zooba
Copy link
MemberAuthor

Want to make sure this is in for 3.12.0b2 tomorrow, but we can look at cleaning up unused options later.

@zoobazooba deleted the gh-103646 branchMay 29, 2023 16:58
zooba added a commit that referenced this pull requestMay 29, 2023
…H-105064)(cherry picked from commit6da7015)Co-authored-by: Steve Dower <steve.dower@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pfmoorepfmoorepfmoore left review comments

Assignees
No one assigned
Labels
OS-windowstype-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@zooba@miss-islington@bedevere-bot@pfmoore
[8]ページ先頭
©2009-2025 Movatter.jp