Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-89886: Properly quote Autoconf macro arguments#105062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aaslanderlend-aasland commentedMay 29, 2023•
edited by bedevere-bot
Loading

Autoconf 2.70 macros are picky about argument quotation.

Autoconf 2.70 macros are picky about argument quotation.
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@erlend-aasland for commit80794c7 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 29, 2023
@erlend-aaslanderlend-aasland added the needs backport to 3.12only security fixes labelMay 29, 2023
@erlend-aasland
Copy link
ContributorAuthor

On hold untiltest_import andtest_peg_generator issues have been resolved onmain.

@erlend-aasland
Copy link
ContributorAuthor

Thanks for the reviews, y'all!

@erlend-aasland
Copy link
ContributorAuthor

Copy link
Member

@gpsheadgpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

thanks for taking this on.

zware reacted with thumbs up emojierlend-aasland reacted with heart emoji
@erlend-aaslanderlend-aaslandenabled auto-merge (squash)May 30, 2023 20:52
@erlend-aaslanderlend-aasland merged commit2ea34cf intopython:mainMay 30, 2023
@miss-islington
Copy link
Contributor

Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@erlend-aasland, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 2ea34cfb3a21182b4d16f57dd6c1cfce46362fe2 3.12

@erlend-aaslanderlend-aasland deleted the autoconf/macro-audit branchMay 30, 2023 21:19
@bedevere-bot
Copy link

GH-105118 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 30, 2023
erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull requestMay 30, 2023
…n#105062)Autoconf 2.70 macros are picky about argument quotation.
erlend-aasland added a commit that referenced this pull requestMay 30, 2023
…105118)Autoconf 2.70 macros are picky about argument quotation.
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.12 has failed when building commitaf7b55d.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1102/builds/44) and take a look at the build logs.
  4. Check if the failure is related to this commit (af7b55d) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1102/builds/44

Failed tests:

  • test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 4, done.remote:Counting objects:  25% (1/4)remote:Counting objects:  50% (2/4)remote:Counting objects:  75% (3/4)remote:Counting objects: 100% (4/4)remote:Counting objects: 100% (4/4), done.remote:Compressing objects:  33% (1/3)remote:Compressing objects:  66% (2/3)remote:Compressing objects: 100% (3/3)remote:Compressing objects: 100% (3/3), done.remote:Total 4 (delta 1), reused 3 (delta 1), pack-reused 0From https://github.com/python/cpython * branch                  3.12       -> FETCH_HEADNote:switching to 'af7b55d37f10594c3aa9815e7b6f0fd8e5ca020f'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at af7b55d37f [3.12] gh-89886: Properly quote Autoconf macro arguments (#105062) (#105118)Switched to and reset branch '3.12'configure:WARNING: pkg-config is missing. Some dependencies may not be detected correctly.Fatal Python error: drop_gil: PyMUTEX_LOCK(gil->switch_mutex) failedPython runtime state: initializedThread 0x00007fc1b4c80280 (most recent call first):  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_mainFatal Python error: AbortedThread 0x00007fc1b4c80280 (most recent call first):  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_mainExtension modules: _testcapi, _xxsubinterpreters (total: 2)Abortedmake:*** [Makefile:2009: buildbottest] Error 134Cannot open file '/root/buildarea/3.12.angelico-debian-amd64/build/test-results.xml' for upload

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@arhadthedevarhadthedevarhadthedev left review comments

@gpsheadgpsheadgpshead approved these changes

@zwarezwarezware approved these changes

@corona10corona10Awaiting requested review from corona10corona10 is a code owner

Assignees

@erlend-aaslanderlend-aasland

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@erlend-aasland@bedevere-bot@miss-islington@gpshead@arhadthedev@zware
[8]ページ先頭
©2009-2025 Movatter.jp