Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105042: Disable unmatched parens syntax error in python tokenize#105061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 3 commits intopython:mainfromlysnikolaou:tokenize-unmatched-parens
May 30, 2023

Conversation

lysnikolaou
Copy link
Member

@lysnikolaoulysnikolaou commentedMay 29, 2023•
edited by bedevere-bot
Loading

@pablogsal
Copy link
Member

We also need a bunch of tests that cover these, one in theinspect module and the other in thetokenize module

@lysnikolaoulysnikolaouforce-pushed thetokenize-unmatched-parens branch from049da25 toed1237aCompareMay 30, 2023 09:55
@lysnikolaoulysnikolaou marked this pull request as ready for reviewMay 30, 2023 09:56
@lysnikolaou
Copy link
MemberAuthor

@pablogsal This is ready for another review.

@pablogsal
Copy link
Member

pablogsal commentedMay 30, 2023•
edited
Loading

We also need a bunch of tests that cover these, one in theinspect module and the other in thetokenize module

Can you add a couple of tests for this?

Maybe something on these lines:#105042 (comment) in the inspect module here:

deftest_parenthesized_multiline_lambda(self):

@lysnikolaou
Copy link
MemberAuthor

@pablogsal Thanks for the reminder! Tests added inc7481a5.

Copy link
Member

@pablogsalpablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Fantastic work!

@pablogsalpablogsal added the needs backport to 3.12only security fixes labelMay 30, 2023
@pablogsalpablogsal merged commit70f315c intopython:mainMay 30, 2023
@miss-islington
Copy link
Contributor

Thanks@lysnikolaou for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 30, 2023
…nize (pythonGH-105061)(cherry picked from commit70f315c)Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
@bedevere-bot
Copy link

GH-105120 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 30, 2023
pablogsal pushed a commit that referenced this pull requestMay 31, 2023
…enize (GH-105061) (#105120)gh-105042: Disable unmatched parens syntax error in python tokenize (GH-105061)(cherry picked from commit70f315c)Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@lysnikolaou@pablogsal@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp