Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-89455: Add missing attributes (added in 3.11) to traceback module docs#105044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 13 commits intopython:mainfromJackenmen:patch-1
May 29, 2023

Conversation

Jackenmen
Copy link
Contributor

@JackenmenJackenmen commentedMay 28, 2023•
edited
Loading

It seems thatexceptions have been missed when the exception groups were added in 3.11.

There are also two new parameters toTracebackException(...) -max_group_depth andmax_group_width. I have only added the documentation for the parameters, not the attributes as modifying the latter wouldn't propagate the value to chained/grouped TracebackExceptions but I can add them if you wish.

I reused the issue number of the original issue that added these parameters/attributes.

I'm sorry for accidentally pinging so many people on#105043, GitHub doesn't warn you about the possibility of pinging people when changing the base :(
image

📚 Documentation preview 📚:https://cpython-previews--105044.org.readthedocs.build/

@iritkatriel
Copy link
Member

I haven't created an issue for this because I figured it's just a documentation fix but I can create one if necessary.

We do create issues for documentation changes as well (unless trivial, as in typo).
In this case you could potentially attach this PR to the issue that added the fields you are documenting.

Jackenmen reacted with thumbs up emoji

Jackenmenand others added2 commitsMay 28, 2023 23:03
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@JackenmenJackenmen changed the titleAdd missing 3.10/11 attributes to traceback module docsGH-89455: Add missing 3.11 attributes to traceback module docsMay 28, 2023
@iritkatrieliritkatriel added docsDocumentation in the Doc dir needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsMay 28, 2023
@iritkatrieliritkatriel changed the titleGH-89455: Add missing 3.11 attributes to traceback module docsGH-89455: Add missing attributes (added in 3.11) to traceback module docsMay 29, 2023
@Jackenmen
Copy link
ContributorAuthor

Subinterpreters got hit by property-based tests, gonna retrigger the run

Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, a few more minor suggestions.

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@iritkatrieliritkatrielenabled auto-merge (squash)May 29, 2023 18:13
@iritkatrieliritkatriel merged commit39f6a04 intopython:mainMay 29, 2023
@miss-islington
Copy link
Contributor

Thanks@Jackenmen for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105066 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 29, 2023
@bedevere-bot
Copy link

GH-105067 is a backport of this pull request to the3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 29, 2023
…odule docs (pythonGH-105044)(cherry picked from commit39f6a04)Co-authored-by: Jakub Kuczys <me@jacken.men>
@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 29, 2023
@JackenmenJackenmen deleted the patch-1 branchMay 29, 2023 18:29
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 29, 2023
…odule docs (pythonGH-105044)(cherry picked from commit39f6a04)Co-authored-by: Jakub Kuczys <me@jacken.men>
iritkatriel pushed a commit that referenced this pull requestMay 29, 2023
…module docs (GH-105044) (#105066)GH-89455: Add missing attributes (added in 3.11) to traceback module docs (GH-105044)(cherry picked from commit39f6a04)Co-authored-by: Jakub Kuczys <me@jacken.men>
iritkatriel pushed a commit that referenced this pull requestMay 29, 2023
…module docs (GH-105044) (#105067)GH-89455: Add missing attributes (added in 3.11) to traceback module docs (GH-105044)(cherry picked from commit39f6a04)Co-authored-by: Jakub Kuczys <me@jacken.men>
@bedevere-bot

This comment was marked as off-topic.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Jackenmen@iritkatriel@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp