Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-105017: Include CRLF lines in strings and column numbers#105030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 10 commits intopython:mainfrommgmacias95:crlf_strings
May 28, 2023

Conversation

mgmacias95
Copy link
Contributor

@mgmacias95mgmacias95 commentedMay 27, 2023•
edited by bedevere-bot
Loading

@pablogsalpablogsal added the needs backport to 3.12only security fixes labelMay 27, 2023
@pablogsalpablogsal changed the titlegh-105017: [Tokenizer] Include CRLF lines in strings and column numbersgh-105017: Include CRLF lines in strings and column numbersMay 27, 2023
@pablogsal
Copy link
Member

There were a bunch of failing tests because we are removing CRLF handling in the regular path that expects the source to be normalized. I pushed a commit that only preserves CRLF in our tokenize extension

@pablogsalpablogsal added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 28, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@pablogsal for commit363de28 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 28, 2023
mgmacias95and others added2 commitsMay 28, 2023 14:55
Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsalpablogsal added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 28, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@pablogsal for commitd3d4ff5 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 28, 2023
@pablogsalpablogsal merged commit96fff35 intopython:mainMay 28, 2023
@miss-islington
Copy link
Contributor

Thanks@mgmacias95 for the PR, and@pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 28, 2023
…thonGH-105030)(cherry picked from commit96fff35)Co-authored-by: Marta Gómez Macías <mgmacias@google.com>Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-105041 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 28, 2023
pablogsal added a commit that referenced this pull requestMay 28, 2023
…H-105030) (#105041)gh-105017: Include CRLF lines in strings and column numbers (GH-105030)(cherry picked from commit96fff35)Co-authored-by: Marta Gómez Macías <mgmacias@google.com>Co-authored-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Member

@pablogsalpablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

Great job! ✨

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Debian root 3.12 has failed when building commit3f8d5d9.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1102/builds/33) and take a look at the build logs.
  4. Check if the failure is related to this commit (3f8d5d9) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1102/builds/33

Failed tests:

  • test_threading
  • test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 16, done.remote:Counting objects:   6% (1/16)remote:Counting objects:  12% (2/16)remote:Counting objects:  18% (3/16)remote:Counting objects:  25% (4/16)remote:Counting objects:  31% (5/16)remote:Counting objects:  37% (6/16)remote:Counting objects:  43% (7/16)remote:Counting objects:  50% (8/16)remote:Counting objects:  56% (9/16)remote:Counting objects:  62% (10/16)remote:Counting objects:  68% (11/16)remote:Counting objects:  75% (12/16)remote:Counting objects:  81% (13/16)remote:Counting objects:  87% (14/16)remote:Counting objects:  93% (15/16)remote:Counting objects: 100% (16/16)remote:Counting objects: 100% (16/16), done.remote:Compressing objects:   6% (1/15)remote:Compressing objects:  13% (2/15)remote:Compressing objects:  20% (3/15)remote:Compressing objects:  26% (4/15)remote:Compressing objects:  33% (5/15)remote:Compressing objects:  40% (6/15)remote:Compressing objects:  46% (7/15)remote:Compressing objects:  53% (8/15)remote:Compressing objects:  60% (9/15)remote:Compressing objects:  66% (10/15)remote:Compressing objects:  73% (11/15)remote:Compressing objects:  80% (12/15)remote:Compressing objects:  86% (13/15)remote:Compressing objects:  93% (14/15)remote:Compressing objects: 100% (15/15)remote:Compressing objects: 100% (15/15), done.remote:Total 16 (delta 1), reused 11 (delta 1), pack-reused 0From https://github.com/python/cpython * branch                  3.12       -> FETCH_HEADNote:switching to '3f8d5d9ed60ae0f70c92dc29587cc6367eda80c3'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 3f8d5d9ed6 [3.12] gh-105017: Include CRLF lines in strings and column numbers (GH-105030) (#105041)Switched to and reset branch '3.12'configure:WARNING: pkg-config is missing. Some dependencies may not be detected correctly.Fatal Python error: Segmentation faultThread 0x00007f253095a280 (most recent call first):  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 74 in _write_status  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 95 in addSuccess  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/testresult.py", line 122 in addSuccess  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 648 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code  File "/root/buildarea/3.12.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_mainExtension modules: _testcapi (total: 1)Segmentation faultmake:*** [Makefile:2009: buildbottest] Error 139Cannot open file '/root/buildarea/3.12.angelico-debian-amd64/build/test-results.xml' for upload

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@pablogsalpablogsalpablogsal left review comments

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@mgmacias95@pablogsal@bedevere-bot@miss-islington
[8]ページ先頭
©2009-2025 Movatter.jp