Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104882: Docs: fix description of relationship betweensocket.getblocking() andsocket.gettimeout()#105026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 3 commits intopython:mainfromjoegeisbauer:fix-issue-104882
Jun 4, 2023

Conversation

joegeisbauer
Copy link
Contributor

@joegeisbauerjoegeisbauer commentedMay 27, 2023•
edited by github-actionsbot
Loading

- Change so that docs properly equate this with socket.gettimeout() != 0.
@ghost
Copy link

ghost commentedMay 27, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@joegeisbauer
Copy link
ContributorAuthor

This issue with the documentation goes back to v3.7.

@arhadthedevarhadthedev added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsMay 27, 2023
@joegeisbauer
Copy link
ContributorAuthor

Will this automatically get marked for review or do I need to do anything special here?

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@AlexWaygoodAlexWaygood self-assigned thisJun 4, 2023
@AlexWaygoodAlexWaygood changed the titlegh-104882: Updated socket documentation for relationship between socket.getblocking() and socket.gettimeout().gh-104882: Docs: fix description of relationship betweensocket.getblocking() andsocket.gettimeout()Jun 4, 2023
@AlexWaygoodAlexWaygood merged commit5a5ed7a intopython:mainJun 4, 2023
@miss-islington
Copy link
Contributor

Thanks@joegeisbauer for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 4, 2023
…t.getblocking()` and `socket.gettimeout()` (pythonGH-105026)(cherry picked from commit5a5ed7a)Co-authored-by: Joe Geisbauer <joegeisbauer@gmail.com>
@bedevere-bot
Copy link

GH-105283 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelJun 4, 2023
@bedevere-bot
Copy link

GH-105284 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelJun 4, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestJun 4, 2023
…t.getblocking()` and `socket.gettimeout()` (pythonGH-105026)(cherry picked from commit5a5ed7a)Co-authored-by: Joe Geisbauer <joegeisbauer@gmail.com>
AlexWaygood pushed a commit that referenced this pull requestJun 4, 2023
…et.getblocking()` and `socket.gettimeout()` (GH-105026) (#105283)gh-104882: Docs: fix description of relationship between `socket.getblocking()` and `socket.gettimeout()` (GH-105026)(cherry picked from commit5a5ed7a)Co-authored-by: Joe Geisbauer <joegeisbauer@gmail.com>
AlexWaygood pushed a commit that referenced this pull requestJun 4, 2023
…et.getblocking()` and `socket.gettimeout()` (GH-105026) (#105284)gh-104882: Docs: fix description of relationship between `socket.getblocking()` and `socket.gettimeout()` (GH-105026)(cherry picked from commit5a5ed7a)Co-authored-by: Joe Geisbauer <joegeisbauer@gmail.com>
@AlexWaygood
Copy link
Member

Thanks@joegeisbauer! I've merged the PR, and backported it to 3.12 and 3.11. Earlier versions of Python now only accept patches if they relate to security issues (which this isn't!), so it won't be backported to 3.10 or earlier.

I removed the NEWS entry before merging, as we don't usually include them for docs-only changes :-)

@joegeisbauerjoegeisbauer deleted the fix-issue-104882 branchJune 4, 2023 17:02
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

@AlexWaygoodAlexWaygood

Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@joegeisbauer@miss-islington@bedevere-bot@AlexWaygood@arhadthedev
[8]ページ先頭
©2009-2025 Movatter.jp