Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: Precompute hash for config cache key in check_source job#105008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 1 commit intopython:mainfromitamaro:precompute-config-hash
May 27, 2023

Conversation

itamaro
Copy link
Contributor

Followup togh-104800, since all the build jobs already depend on the check_source job, we can precompute the hash in that job and reuse it in the downstream jobs.

While the time saving is negligible, the main benefit of this change is that the list of hashed files is not repeated in multiple places.

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nicely done, thanks!

@hugovkhugovk merged commit949f0f5 intopython:mainMay 27, 2023
@hugovkhugovk added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsMay 27, 2023
@miss-islington
Copy link
Contributor

Thanks@itamaro for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@itamaro for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@itamaro and@hugovk, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.11

@miss-islington
Copy link
Contributor

Sorry@itamaro and@hugovk, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 949f0f5bb07d94f8882135a1d58d82c0a2b289a9 3.12

@hugovk
Copy link
Member

hugovk commentedMay 27, 2023•
edited
Loading

@itamaro Please could you backport these to3.12 and 3.11?

itamaro reacted with thumbs up emoji

@hugovkhugovk added needs backport to 3.12only security fixes and removed needs backport to 3.12only security fixes labelsMay 27, 2023
@miss-islington
Copy link
Contributor

Thanks@itamaro for the PR, and@hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105014 is a backport of this pull request to the3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 27, 2023
…H-105008)(cherry picked from commit949f0f5)Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 27, 2023
hugovk pushed a commit that referenced this pull requestMay 27, 2023
@bedevere-bot
Copy link

GH-105024 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 27, 2023
@erlend-aasland
Copy link
Contributor

Nice; thanks!

@itamaroitamaro deleted the precompute-config-hash branchApril 9, 2024 15:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

@ezio-melottiezio-melottiAwaiting requested review from ezio-melottiezio-melotti is a code owner

Assignees

@hugovkhugovk

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@itamaro@miss-islington@hugovk@bedevere-bot@erlend-aasland@arhadthedev
[8]ページ先頭
©2009-2025 Movatter.jp