Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104839: Prevent test_venv AddressSanitizer spam#105005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 1 commit intopython:mainfromgpshead:test_venv_asan
May 27, 2023

Conversation

@gpshead
Copy link
Member

@gpsheadgpshead commentedMay 26, 2023•
edited
Loading

Pass any ASAN_OPTIONS environment variable through to the child process so that leak sanitizer being disabled on our CI and buildbots stays true in the children.

Fixes#104839.

Pass any ASAN_OPTIONS environment variable through to the child processso that leak sanitizer being disabled on our CI and buildbots staystrue in the children.
@gpshead
Copy link
MemberAuthor

Only 596 lines of output in the Address Sanitizer Tests CI run. Yay, normal. No longer 50,000 and 5MiB.

@gpsheadgpshead merged commita17f160 intopython:mainMay 27, 2023
@miss-islington
Copy link
Contributor

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@gpsheadgpshead deleted the test_venv_asan branchMay 27, 2023 01:15
@miss-islington
Copy link
Contributor

Sorry,@gpshead, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker a17f160376955d369c8d332e1b1a90a6e18c852a 3.11

@miss-islington
Copy link
Contributor

Sorry@gpshead, I had trouble checking out the3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker a17f160376955d369c8d332e1b1a90a6e18c852a 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 27, 2023
…5005)Pass any ASAN_OPTIONS environment variable through to the child processso that leak sanitizer being disabled on our CI and buildbots staystrue in the children.(cherry picked from commita17f160)Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

GH-105006 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 27, 2023
@gpsheadgpshead removed needs backport to 3.10only security fixes needs backport to 3.11only security fixes labelsMay 27, 2023
gpshead added a commit that referenced this pull requestMay 27, 2023
…#105006)gh-104839: Prevent test_venv AddressSanitizer spam (GH-105005)Pass any ASAN_OPTIONS environment variable through to the child processso that leak sanitizer being disabled on our CI and buildbots staystrue in the children.(cherry picked from commita17f160)Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vsajipvsajipAwaiting requested review from vsajipvsajip is a code owner

Assignees

@gpsheadgpshead

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_venv spams our AddressSanitizer CI with 5mb of test logs

3 participants

@gpshead@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp