Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104984: remove kwargs and starargs from Call & ClassDef#104986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
carljm merged 1 commit intopython:mainfromGlyphack:main
May 26, 2023

Conversation

Glyphack
Copy link
Contributor

@GlyphackGlyphack commentedMay 26, 2023•
edited by github-actionsbot
Loading

@ghost
Copy link

ghost commentedMay 26, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

Copy link
Member

@carljmcarljm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the PR! I verified that these arguments (and attributes) indeed don't exist anymore. Impressive that nobody noticed this until now in the 8(!) years since they were removed.

ghodsizadeh reacted with laugh emoji
@@ -1820,7 +1820,7 @@ Function and class definitions
type_ignores=[])


.. class:: ClassDef(name, bases, keywords,starargs, kwargs,body, decorator_list)
.. class:: ClassDef(name, bases, keywords, body, decorator_list)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is also now out of date with the implementation in main and 3.12 due to the addition oftype_params argument in PEP 695, but that's being addressed in#104642

Still seems sensible to removestarargs andkwargs in this PR, and let@JelleZijlstra resolve the resulting conflict on this line in#104642

JelleZijlstra reacted with thumbs up emoji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Hmm, backporting this will mean that the PEP 695 docs PR won't backport cleanly, which may cause a bit more of a pain.@JelleZijlstra how do you prefer to handle this?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just merge this first, I'll take care of the backports

carljm reacted with thumbs up emoji
@JelleZijlstraJelleZijlstra added needs backport to 3.11only security fixes needs backport to 3.12only security fixes labelsMay 26, 2023
@carljmcarljm merged commit61c1d67 intopython:mainMay 26, 2023
@miss-islington
Copy link
Contributor

Thanks@Glyphack for the PR, and@carljm for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 26, 2023
…honGH-104986)These fields are removed inpython@025e9eb(cherry picked from commit61c1d67)Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
@bedevere-bot
Copy link

GH-104987 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 26, 2023
@bedevere-bot
Copy link

GH-104988 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 26, 2023
…honGH-104986)These fields are removed inpython@025e9eb(cherry picked from commit61c1d67)Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
carljm pushed a commit that referenced this pull requestMay 26, 2023
…-104986) (#104987)gh-104984: remove kwargs and starargs from Call & ClassDef (GH-104986)These fields are removed in025e9eb(cherry picked from commit61c1d67)Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
AlexWaygood pushed a commit that referenced this pull requestMay 26, 2023
…-104986) (#104988)gh-104984: remove kwargs and starargs from Call & ClassDef (GH-104986)These fields are removed in025e9eb(cherry picked from commit61c1d67)Co-authored-by: Shaygan Hooshyari <sh.hooshyari@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@carljmcarljmcarljm approved these changes

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

starargs and kwargs are removed from ClassDef and Call ast nodes
5 participants
@Glyphack@miss-islington@bedevere-bot@carljm@JelleZijlstra
[8]ページ先頭
©2009-2025 Movatter.jp