Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-104976: Ensure trailing dedent tokens are emitted as the previous tokenizer#104980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
7c0113e
to6db032a
Compare@pablogsal Can you provide a very quick explanation of how this works and changes the location of the DEDENT token? Nothing too detailed, just a quick overview of the though process, cause I'm having difficulties understanding this. |
Yep: the objective is that inplicit dedents like these:
are reported in the same line as the Unfortunately, this forces us to handle |
Tell me if something else is not clear:) |
Ah wait, I forgot to push some commits 😓 |
lysnikolaou commentedMay 26, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Aha! Ok, makes sense now. Thanks for the explanation though, man! |
8a23a18
to19a58c5
Compare
Sorry for the confusion! 😅 Check again when you have time! |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yup! Looks good!
…vious tokenizerSigned-off-by: Pablo Galindo <pablogsal@gmail.com>
Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
bedevere-bot commentedMay 26, 2023
GH-105000 is a backport of this pull request to the3.12 branch. |
…vious tokenizer (pythonGH-104980)(cherry picked from commit46b52e6)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.