Movatterモバイル変換

JelleZijlstra requested a review fromAlexWaygood

May 26, 2023 05:03

bedevere-bot added awaiting core review docsDocumentation in the Doc dir labels

Remove duplicate mention of override, add two others

0c8dfb1

JelleZijlstra changed the title~~Document PEP 698 in Whats New~~Document PEP 698 and other new typing features in What's New

Copy link

MemberAuthor

JelleZijlstra commentedMay 26, 2023

I looked overgit diff 3.11 3.12 Lib/typing.py and noticed two more changes that deserve to be mentioned:@adriangb's work on__orig_bases__ and@debonte's addition offrozen_default.

AlexWaygood reviewed

Doc/whatsnew/3.12.rst OutdatedShow resolvedHide resolved

Doc/whatsnew/3.12.rst

		@@ -755,6 +778,13 @@ typing
		or more members may be slower than in Python 3.11. (Contributed by Alex
		Waygood in :gh:`74690` and :gh:`103193`.)

		* All :data:`typing.TypedDict` and :data:`typing.NamedTuple` classes now have the
		``__orig_bases__`` attribute. (Contributed by Adrian Garcia Badaracco in

Copy link

Member

AlexWaygoodMay 26, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Given that this attribute is undocumented (and I'd prefer it to stay that way, though that's not astrong opinion), could we add this something like "this ensures thattypes.get_original_bases(typeddict_class) will now always return the correct result"?

Copy link

MemberAuthor

JelleZijlstraMay 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Maybe we could say "now work reliably with :func:types.get_original_bases", although that's a bit of a vacuous statement astypes.get_original_bases didn't exist before 3.12 :)

Copy link

Member

AlexWaygoodMay 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Eh, I guess you're right, it's probably fine as it is

Update Doc/whatsnew/3.12.rst

e460c59

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

AlexWaygood approved these changes

bedevere-bot added awaiting merge and removed awaiting core review labels

stroxler approved these changes

Copy link

Contributor

stroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The PEP 698 section looks good to me, thanks!

hauntsaninja approved these changes

hauntsaninja merged commit595ffdd intopython:main

Copy link

Contributor

miss-islington commentedMay 28, 2023

Thanks@JelleZijlstra for the PR, and@hauntsaninja for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

bedevere-bot removed the awaiting merge label

Copy link

bedevere-bot commentedMay 28, 2023

GH-105045 is a backport of this pull request to the3.12 branch.

bedevere-bot removed the needs backport to 3.12only security fixes label

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Document PEP 698 and other new typing features in What's New (pythonG…

63c9055

…H-104957)(cherry picked from commit595ffdd)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

hauntsaninja pushed a commit that referenced this pull request

3.12 backport gh 105236#105358

[3.12] Document PEP 698 and other new typing features in What's New (G…

74bbc60

…H-104957) (#105045)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

erlend-aasland mentioned this pull request

Jun 6, 2023

Closed

rinarakaki reviewed

Oct 3, 2023