Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms#104948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
barneygale merged 3 commits intopython:mainfrombarneygale:gh-104947-pathlib-use-str-lowerMay 26, 2023
Merged
GH-104947: Make pathlib.PureWindowsPath comparisons consistent across platforms#104948
barneygale merged 3 commits intopython:mainfrombarneygale:gh-104947-pathlib-use-str-lowerMay 26, 2023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…across OSsUse `str.lower()` rather than `ntpath.normcase()` to normalize case ofWindows paths. This restores behaviour from Python 3.11.
gpshead approved these changesMay 26, 2023
Thanks@barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 26, 2023
…across platforms (pythonGH-104948)Use `str.lower()` rather than `ntpath.normcase()` to normalize case ofWindows paths. This restores behaviour from Python 3.11.(cherry picked from commitad0be36)Co-authored-by: Barney Gale <barney.gale@gmail.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>
bedevere-bot commentedMay 26, 2023
GH-104990 is a backport of this pull request to the3.12 branch. |
barneygale added a commit that referenced this pull requestMay 26, 2023
… across platforms (GH-104948) (GH-104990)Use `str.lower()` rather than `ntpath.normcase()` to normalize case ofWindows paths. This restores behaviour from Python 3.11.(cherry picked from commitad0be36)Co-authored-by: Barney Gale <barney.gale@gmail.com>Co-authored-by: Gregory P. Smith <greg@krypto.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Use
str.lower()rather thanntpath.normcase()to normalize case of Windows paths. This restores behaviour from Python 3.11.