Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104935: typing: Fix interactions between @runtime_checkable and Generic#104939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 5 commits intopython:mainfromJelleZijlstra:is_protocol
May 25, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMay 25, 2023•
edited by bedevere-bot
Loading

JelleZijlstraand others added3 commitsMay 25, 2023 09:12
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstraJelleZijlstra changed the titlegh-104935: Add back typing.Generic._is_protocolgh-104935: typing: Fix interactions between @runtime_checkable and GenericMay 25, 2023
@AlexWaygoodAlexWaygood removed the request for review frommarkshannonMay 25, 2023 16:22
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks!

@miss-islington
Copy link
Contributor

Thanks@JelleZijlstra for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@JelleZijlstra and@AlexWaygood, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker 2b7027d0b2ee2e102a24a0da27d01b8221f9351c 3.12

@AlexWaygoodAlexWaygood added needs backport to 3.12only security fixes and removed needs backport to 3.12only security fixes labelsMay 25, 2023
@miss-islington
Copy link
Contributor

Thanks@JelleZijlstra for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstraJelleZijlstra removed the needs backport to 3.12only security fixes labelMay 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 25, 2023
…` and `Generic` (pythonGH-104939)---------(cherry picked from commit2b7027d)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-104941 is a backport of this pull request to the3.12 branch.

@JelleZijlstraJelleZijlstra added the needs backport to 3.12only security fixes labelMay 25, 2023
@miss-islington
Copy link
Contributor

Thanks@JelleZijlstra for the PR, and@AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstraJelleZijlstra deleted the is_protocol branchMay 25, 2023 16:44
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 25, 2023
…` and `Generic` (pythonGH-104939)---------(cherry picked from commit2b7027d)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstra
Copy link
MemberAuthor

oops

@AlexWaygood
Copy link
Member

Yeah you made@miss-islington force-push to her PR branch!

JelleZijlstra reacted with confused emoji

AlexWaygood added a commit that referenced this pull requestMay 25, 2023
…e` and `Generic` (GH-104939) (#104941)gh-104935: typing: Fix interactions between `@runtime_checkable` and `Generic` (GH-104939)---------(cherry picked from commit2b7027d)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@JelleZijlstraJelleZijlstra restored the is_protocol branchSeptember 10, 2024 23:37
@ZeroIntensityZeroIntensity removed the needs backport to 3.12only security fixes labelFeb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees

@AlexWaygoodAlexWaygood

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@JelleZijlstra@miss-islington@bedevere-bot@AlexWaygood@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp