Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-104773: PEP 594: Remove the aifc module#104933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 3 commits intopython:mainfromvstinner:remove_aifc
May 25, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMay 25, 2023
edited by github-actionsbot
Loading

@vstinner
Copy link
MemberAuthor

Please see thePEP 594 section about aifc:

A user disclosed that the post production film industry makes heavy use of the AIFC file format. The usage of the aifc module in closed source and internal software was unknown prior to the first posting of this PEP.This may be a compelling argument to keep the aifc module in the standard library. The file format is stable and the module does not require much maintenance. The strategic benefits for Python may outmatch the burden.

PEP 594 got accepted, so I understood thatthe Steering Council took these arguments in account andis fine with removing the aifc module from the Python stdlib.

test_aifc uses the audioop module which prevents the removal of the audioop module. If we want to keep the aifc module but remove audioop ,test_aifc should be rewritten without audioop.

@hugovk
Copy link
Member

Can we remove these test files as well?

./Lib/test/audiodata/pluck-ulaw.aifc./Lib/test/audiodata/pluck-alaw.aifc./Lib/test/Sine-1000Hz-300ms.aif

@vstinner
Copy link
MemberAuthor

Someone else wrote a less complete PR: PR#104927.

* Remove .aifc and .aiff test files of Lib/test/audiodata/.* Remove Lib/test/Sine-1000Hz-300ms.aif test file.
@vstinner
Copy link
MemberAuthor

Can we remove these test files as well?

Right. I remove these test files and a few more.

@vstinner
Copy link
MemberAuthor

With this change, test_wave becomes the last user ofLib/test/audiotests.py. I don't think that it's worth it to move the code into Lib/test/test_wave.py. I prefer to leave it as it is for now.

The two remaining AIFC test files are used by test_email:

Lib/test/test_email/data/sndhdr.aifcLib/test/test_email/data/sndhdr.aiff

@vstinner
Copy link
MemberAuthor

Thechunk module is related to AIFF: I wrote PR#104868 to remove it.

@vstinner
Copy link
MemberAuthor

I added a What's New in Python 3.13 and Changelog entry.

hugovk reacted with thumbs up emoji

@vstinner
Copy link
MemberAuthor

A user disclosed that the post production film industry makes heavy use of the AIFC file format.

The VFX platform still uses Python 3.10 in 2023 ("CY2023"):https://vfxplatform.com/ Python will be upgraded to Python 3.11 next year ("CY2024 DRAFT").

@vstinner
Copy link
MemberAuthor

See also issue#105096: wave: Deprecate getmark(), setmark() and getmarkers() methods.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@hugovk@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp