Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104773: PEP 594: Remove the aifc module#104927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
fatelei wants to merge1 commit intopython:mainfromfatelei:remove_aifc

Conversation

fatelei
Copy link

@fateleifatelei commentedMay 25, 2023•
edited by github-actionsbot
Loading

@ghost
Copy link

ghost commentedMay 25, 2023•
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@hugovkhugovk changed the titlegh-104773: remove aifc modulegh-104773: Remove the aifc moduleMay 25, 2023
@hugovkhugovk changed the titlegh-104773: Remove the aifc modulegh-104773: PEP 594: Remove the aifc moduleMay 25, 2023
Copy link
Contributor

@DBJimDBJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks like the cause of docs test failure

@@ -1731,7 +1731,7 @@ Modules
slated for removal in Python 3.13:

+---------------------+---------------------+---------------------+---------------------+---------------------+
| :mod:`aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` |
| :mod:`!aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
|:mod:`!aifc`| :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` |
|:mod:`!aifc` | :mod:`chunk` | :mod:`!msilib` | :mod:`!pipes` | :mod:`!telnetlib` |

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wrote a more complete PR: PR#104933.

@@ -1,6 +1,5 @@
# Binary data types
*.aif binary
*.aifc binary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think that this change is correct. TheLib/test/test_email/data/sndhdr.aifc file should still be treated as binary by Git.

@vstinner
Copy link
Member

Thanks for your contribution! I merged my PR#104933 instead (more complete).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner left review comments

@DBJimDBJimDBJim left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@fatelei@vstinner@DBJim@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp