Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104924: Fixread()able inhttp.client log messages#104926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
corona10 merged 2 commits intopython:mainfromarhadthedev:http-read-able
May 26, 2023

Conversation

arhadthedev
Copy link
Member

@arhadthedevarhadthedev commentedMay 25, 2023•
edited by bedevere-bot
Loading

LyingDalai reacted with thumbs up emoji
Copy link
Member

@gaogaotiantiangaogaotiantian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I thinksendIng is an obvious typo. On line 1057, from some brief reading, it's not "sending" a readable, but "reading" from a readable(as indicated by the function name).

arhadthedev reacted with thumbs up emoji
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
@LyingDalai
Copy link

I have looked for any related typo with “Ing the read()”. I know PyCharm can make funny replacements but I still haven’t found where this would come from.

Copy link
Member

@corona10corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm

@miss-islington
Copy link
Contributor

Thanks@arhadthedev for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 26, 2023
…ongh-104926)(cherry picked from commit6c81d75)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-bot
Copy link

GH-104970 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 26, 2023
@bedevere-bot
Copy link

GH-104971 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 26, 2023
…ongh-104926)(cherry picked from commit6c81d75)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@arhadthedevarhadthedev deleted the http-read-able branchMay 26, 2023 11:53
corona10 pushed a commit that referenced this pull requestMay 26, 2023
…104926) (gh-104971)gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)(cherry picked from commit6c81d75)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
corona10 pushed a commit that referenced this pull requestMay 26, 2023
…104926) (gh-104970)gh-104924: Fix `read()able` in `http.client` log messages (gh-104926)(cherry picked from commit6c81d75)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@corona10corona10corona10 approved these changes

@gaogaotiantiangaogaotiantiangaogaotiantian approved these changes

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@arhadthedev@LyingDalai@miss-islington@bedevere-bot@corona10@gaogaotiantian
[8]ページ先頭
©2009-2025 Movatter.jp