Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-104924: Fixread()able
inhttp.client
log messages#104926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I thinksendIng
is an obvious typo. On line 1057, from some brief reading, it's not "sending" a readable, but "reading" from a readable(as indicated by the function name).
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Tian Gao <gaogaotiantian@hotmail.com>
LyingDalai commentedMay 25, 2023
I have looked for any related typo with “Ing the read()”. I know PyCharm can make funny replacements but I still haven’t found where this would come from. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
lgtm
Thanks@arhadthedev for the PR, and@corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
…ongh-104926)(cherry picked from commit6c81d75)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
bedevere-bot commentedMay 26, 2023
GH-104970 is a backport of this pull request to the3.12 branch. |
bedevere-bot commentedMay 26, 2023
GH-104971 is a backport of this pull request to the3.11 branch. |
…ongh-104926)(cherry picked from commit6c81d75)Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
Uh oh!
There was an error while loading.Please reload this page.
https://github.com/search?q=repo%3Apython%2Fcpython%20read()able&type=code shows no other occurrence of this typo.