Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-104773: PEP 594: Remove the msilib package#104911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zware merged 2 commits intopython:mainfromzware:no_more_msilib
May 25, 2023

Conversation

zware
Copy link
Member

@zwarezware commentedMay 24, 2023
edited by github-actionsbot
Loading

@vstinner
Copy link
Member

msilib/__init__.py starts withfrom _msi import *: the _msi extension should be removed as well, no? Do you plan to remove it as a separated PR?

@vstinner
Copy link
Member

Note: The msilib module was used by thebdist_msi command of distutils, but this command was removed in Python 3.11, and the whole distutils package was removed in Python 3.12. See the bdist_msi deprecation in Python 3.9 for the rationale: issue#83767.

Now it's fine to remove this deprecated msilib module. Well,PEP 594 has a longer rationale.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM.

The _msi extension can be removed in a separated PR.

@vstinner
Copy link
Member

Usingimport msilib|from msilib regex, I found the following projects of PyPI top 5,000 projects (at 2023-04-13) using the removed msilib module.

Affected projects (2):

  • mpi4py (3.1.4)
  • pygame (2.3.0)
pygame-2.3.0/setup.py: import msilibmpi4py-3.1.4/conf/mpidistutils.py: import msilib

@zwarezware requested a review froma team as acode ownerMay 25, 2023 00:12
@zwarezware requested a review fromvstinnerMay 25, 2023 00:12
@vstinner
Copy link
Member

DoesTools\msi\build.bat use msilib module or _msi extension? Or does it use Windows tooling instead?

There is.github/workflows/build_msi.yml which runsTools\msi\build.bat, but I don't know what triggers this GHA job. Is it when one file inTools/msi/ is modified?

It may be interesting to check that these tools and/or this GHA job still work ;-)

@vstinner
Copy link
Member

Oh wait, I see aTestsMSI / Windows Installer (x64) (pull_request) In progress task running! It will tell us if it still works :-)

zware reacted with thumbs up emoji

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. The msilib LGTM. For the _msi removal, I'm not 100% confident that I can review the VS solution changes (but from what I saw, it LGTM as well).

@zwarezware merged commit98c4333 intopython:mainMay 25, 2023
@zwarezware deleted the no_more_msilib branchMay 25, 2023 01:06
@hugovkhugovk changed the titlegh-104773: Remove the msilib packagegh-104773: PEP 594: Remove the msilib packageMay 25, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vstinnervstinnervstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@zware@vstinner@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp