NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-104773: PEP 594: Remove the crypt module#104908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 1 commit intopython:mainfromvstinner:remove_crypt

May 25, 2023

Merged

gh-104773: PEP 594: Remove the crypt module#104908

vstinner merged 1 commit intopython:mainfromvstinner:remove_crypt

May 25, 2023

Conversation

Copy link

Member

vstinner commentedMay 24, 2023•
edited by github-actionsbot
Loading

Remove the crypt module and its private _crypt extension, deprecated in Python 3.11.

Issue:PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773

📚 Documentation preview 📚:https://cpython-previews--104908.org.readthedocs.build/

vstinner requested review fromerlend-aasland andcorona10 ascode owners

May 24, 2023 23:26

bedevere-bot added the awaiting core review label

May 24, 2023

bedevere-bot mentioned this pull request

May 24, 2023

PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13#104773

Closed

19 tasks

Copy link

MemberAuthor

vstinner commentedMay 24, 2023

Using^\s*(import crypt\b|from crypt\b) regex, I found the following PyPI top 5,000 projects using the removed crypt module.

Affected projects (8):

Django (4.2)
Twisted (22.10.0)
ansible (7.4.0)
ansible-core (2.14.4)
htpasswd (2.3)
passlib (1.7.4)
pyftpdlib (1.5.7)
pytest-testinfra (7.0.0)

Code:

Django-4.2/tests/auth_tests/test_hashers.py: import cryptansible-7.4.0/ansible_collections/community/general/plugins/modules/homectl.py: import cryptansible-7.4.0/ansible_collections/community/general/plugins/modules/udm_user.py: import cryptTwisted-22.10.0/src/twisted/conch/test/test_checkers.py: import cryptTwisted-22.10.0/src/twisted/cred/test/test_cred.py: from crypt import crypt as _cryptTwisted-22.10.0/src/twisted/plugins/cred_unix.py: import cryptansible-core-2.14.4/lib/ansible/utils/encrypt.py: import cryptpasslib-1.7.4/passlib/tests/utils.py: from crypt import cryptpasslib-1.7.4/passlib/utils/__init__.py: from crypt import crypt as _cryptpyftpdlib-1.5.7/pyftpdlib/authorizers.py: import cryptpytest-testinfra-7.0.0/test/test_modules.py: import crypthtpasswd-2.3/htpasswd/basic.py: from crypt import crypt

Copy link

MemberAuthor

vstinner commentedMay 24, 2023

passlib (1.7.4)

It's interesting that the proposed replacement for the removed crypt module actually uses crypt internally (in/passlib/utils/__init__.py) :-)

zware approved these changes

May 25, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 25, 2023

Copy link

Member

hugovk commentedMay 25, 2023

Are these bits still needed?

Lib/ctypes/util.py366:            print(f"crypt\t:: {find_library('crypt')}")367:            print(f"crypt\t:: {cdll.LoadLibrary(find_library('crypt'))}")373:            print(find_library("crypt"))

pythongh-104773: PEP 594: Remove the crypt module

640eea3

Remove the crypt module and its private _crypt extension, deprecatedin Python 3.11.

vstinner force-pushed theremove_crypt branch fromb9ae871 to640eea3Compare

May 25, 2023 12:28

Copy link

MemberAuthor

vstinner commentedMay 25, 2023

Are these bits still needed?

IMO we should keep it. I saw this test in ctypes. I don't see any direct relationship with the Python crypt module. It's just a test to load a dynamic library which is commonly available on Unix.