Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
Small speedup for dataclass __eq__ and __repr__#104904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good!
Those look great,@rhettinger! Thanks. I'll do a detailed code review then commit it. |
* main: CI: Temporarily skip paths with spaces to avoid error (python#105110)pythongh-105071: add missing versionadded directive (python#105097)pythongh-80064: Fix is_valid_wide_char() return type (python#105099) Small speedup for dataclass __eq__ and __repr__ (python#104904)pythongh-103921: Minor PEP-695 fixes to the `ast` module docs (python#105093)pythongh-105091: stable_abi.py: Remove "Unixy" check from --all on other platforms (pythonGH-105092)
I belive I found a regression:#116647 |
Or you found that this resulted in a perhaps inadvertent bugfix ;-). Depends on Eric's intention for NANs in dataclasses. |
__eq__
do a series ofand
comparisons rather than building a tuple and relying ontuple.__eq__
.__repr__
put the type name in the f-string rather than calling string concatenation explicitly.Old code:
New code:
Timings for a dataclass with two integer fields: