Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-75552: Remove deprecated tkinter.tix module#104902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zware merged 2 commits intopython:mainfromzware:so_long_and_thanks_for_all_the_Tix
May 27, 2023

Conversation

zware
Copy link
Member

@zwarezware commentedMay 24, 2023
edited by github-actionsbot
Loading

@zwarezware requested a review froma team as acode ownerMay 24, 2023 22:51
@zwarezwareforce-pushed theso_long_and_thanks_for_all_the_Tix branch 3 times, most recently from72026c5 toe7abc51CompareMay 24, 2023 23:36
@zooba
Copy link
Member

If you haven't rebuilt the MSI yourself, might be worth touching something in the tools/msi directory so that the PR tests run. I don't think there are any Tix-specific dependencies in it though, so it ought to be fine.

@zware
Copy link
MemberAuthor

Ah, hmm. Because of the way Tcl/Tk/Tix is packaged incpython-bin-deps, should we create atcltk-8.6.13.1 without tix?

@zwarezwareforce-pushed theso_long_and_thanks_for_all_the_Tix branch frome7abc51 to0524a21CompareMay 25, 2023 02:18
@zware
Copy link
MemberAuthor

I suppose at worst thetix libraries just become dead weight in thetcltk installation, and the next time we build a new Tcl/Tk bundle for a new version, the dead weight will be removed.

Interestingly, theTestsMSI workflows "passed", but each one with 4 warnings and 2 errors. This is not new to this PR, though so I won't hold this up based on that. I would like a positive review from someone before I click the button, though :)

@zooba
Copy link
Member

Yeah, there'll be updates needed tohttps://github.com/python/release-tools/blob/master/windows-release/tcltk-build.yml, which is where the "real" build happens. I can do that.

We probably need to tag builds separately for "without Tix" unless we've got a major version update coming (i.e. one that won't be used for 3.12)?

zware reacted with thumbs up emoji

@zooba
Copy link
Member

Interestingly, theTestsMSI workflows "passed", but each one with 4 warnings and 2 errors.

The warnings are all expected... the errors are because we don't build the docs first in that job. I've just filed#104929 to fix that, so if you want to wait and merge it before merging this, that ought to give you clean results?

zware reacted with hooray emoji

@hugovk
Copy link
Member

Nice branch name! :)

Can some of this stuff be removed?

Modules/tkappinit.c63:#ifdef WITH_TIX65:        extern int Tix_Init(Tcl_Interp *interp);66:        extern int Tix_SafeInit(Tcl_Interp *interp);67:        Tcl_StaticPackage(NULL, "Tix", Tix_Init, Tix_SafeInit);Lib/idlelib/help.html30:    <link rel="prev" title="tkinter.tix — Extension widgets for Tk" href="tkinter.tix.html" />126:    <p><a href="tkinter.tix.html"127:                          title="previous chapter"><code><span>tkinter.tix</span></code> — Extension widgets for Tk</a></p>163:          <a href="tkinter.tix.html" title="tkinter.tix — Extension widgets for Tk"1080:    <p><a href="tkinter.tix.html"1081:                          title="previous chapter"><code><span>tkinter.tix</span></code> — Extension widgets for Tk</a></p>1120:          <a href="tkinter.tix.html" title="tkinter.tix — Extension widgets for Tk"Modules/Setup225:# specific extension (e.g. Tix or BLT), leave the corresponding line242:# *** Uncomment and edit for Tix extension only:243:# -DWITH_TIX -ltix8.1.8.2 \

@zooba
Copy link
Member

zooba commentedMay 25, 2023
edited
Loading

See alsopython/release-tools#47 where I'm making the Tix build step optional for the cpython-bin-deps build.

The package from my test run is athttps://dev.azure.com/Python/cpython/_build/results?buildId=128771&view=artifacts&pathAsName=false&type=publishedArtifacts (for about 30 days I expect) if you want to check that it works. You shouldn't need to log in, but all you can do is click the three dots at the right of thetcltk item to download it.

zware reacted with thumbs up emoji

@zware
Copy link
MemberAuthor

Can some of this stuff be removed?

I opted to keep theWITH_TIX bits intkappinit.c andModules/Setup because they're not actually related to including Tix with Python, they're available for someone building something into tkinter specially. There are otherWITH_* defs in the surrounding code for Tcl modules that we've never included.

The mentions inidlelib/help.html should go away next time that file is regenerated. I tried it out, but introduced several more changes due to Sphinx version mismatch, so I left it for now. Those bits shouldn't actually be relevant to its use anyway.

hugovk reacted with thumbs up emoji

@jneb
Copy link
Contributor

There still is no alternative for the tix module. The Select and Balloon classes are nowhere to be found, no Python replacement, and ttk doesn't even look like tix. What are the poor users to do?

@zware
Copy link
MemberAuthor

Tix has been unmaintained for 10 years now, has open security vulnerabilities, and every update of anything in our toolchain risks breaking it. If you still need it, it's open source and can be vendored into your project or maintained separately, but we will no longer provide it out of the box as of Python 3.13.

taleinat reacted with thumbs up emoji

@zwarezwareforce-pushed theso_long_and_thanks_for_all_the_Tix branch fromc8d477d to99efec0CompareMay 26, 2023 17:06
@zwarezwareforce-pushed theso_long_and_thanks_for_all_the_Tix branch from99efec0 to27c8d16CompareMay 26, 2023 17:08
@zwarezware merged commita989b73 intopython:mainMay 27, 2023
@zwarezware deleted the so_long_and_thanks_for_all_the_Tix branchMay 27, 2023 17:34
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@zware@zooba@hugovk@jneb@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp