NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-104773: PEP 594: Remove the nis module#104897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vstinner merged 3 commits intopython:mainfromvstinner:remove_nis

May 24, 2023

Merged

gh-104773: PEP 594: Remove the nis module#104897

vstinner merged 3 commits intopython:mainfromvstinner:remove_nis

May 24, 2023

Conversation

Copy link

Member

vstinner commentedMay 24, 2023•
edited by github-actionsbot
Loading

Issue:PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13 #104773

📚 Documentation preview 📚:https://cpython-previews--104897.org.readthedocs.build/

pythongh-104773: PEP 594: Remove the nis module

dbc4742

vstinner requested review fromerlend-aasland andcorona10 ascode owners

May 24, 2023 21:19

bedevere-bot added the awaiting core review label

May 24, 2023

bedevere-bot mentioned this pull request

May 24, 2023

PEP 594: Remove stdlib modules scheduled for deletion in Python 3.13#104773

Closed

19 tasks

Copy link

Member

hugovk commentedMay 24, 2023

Some extra nismodule / libnsl bits to remove?

Tools/c-analyzer/cpython/ignored.tsv285:Modules/nismodule.c  -       TIMEOUT -286:Modules/nismodule.c  -       aliases -Tools/c-analyzer/cpython/_parser.py123:Modules/nismodule.c  /usr/include/tirpcTools/c-analyzer/cpython/globals-to-fix.tsv458:Modules/nismodule.c  nisproc_maplist_2       res     -PC/pyconfig.h679:#define HAVE_LIBNSL 1

vstinner requested a review froma team as acode owner

May 24, 2023 21:31

Remove more references to nsl library, NIS and nismodule

3f25903

vstinner force-pushed theremove_nis branch from4530100 to3f25903Compare

May 24, 2023 21:31

Copy link

MemberAuthor

vstinner commentedMay 24, 2023

Some extra nismodule / libnsl bits to remove?

Well spotted: removed as well.

For now, I prefer to keep this code in configure.ac, since I don't know its purpose and I cannot test a change on Solaris:

$ git grep -B1 -A1 '\<nsl\>'configure.ac-# Most SVR4 platforms (e.g. Solaris) need -lsocket and -lnsl.configure.ac:AC_CHECK_LIB(nsl, t_open, [LIBS="-lnsl $LIBS"]) # SVR4configure.ac-AC_CHECK_LIB(socket, socket, [LIBS="-lsocket $LIBS"], [], $LIBS) # SVR4 sockets