Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104786: Remove kwargs-based TypedDict creation#104891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
AlexWaygood merged 10 commits intopython:mainfromtomasr8:typeddict-kwargs-removal
May 25, 2023

Conversation

tomasr8
Copy link
Member

@tomasr8tomasr8 commentedMay 24, 2023•
edited by bedevere-bot
Loading

Not sure if/how I should update the docs:

..deprecated-removed::3.11 3.13
The keyword-argument syntax is deprecated in 3.11 and will be removed
in 3.13. It may also be unsupported by static type checkers.

Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

tomasr8 reacted with thumbs up emoji
@AlexWaygood
Copy link
Member

AlexWaygood commentedMay 24, 2023•
edited
Loading

Not sure if/how I should update the docs:

I would remove the existingdeprecated-removed note, and add something like:

..versionchanged::3.13   Removed support for the keyword-argument method of creating ``TypeDict``\s.
tomasr8 reacted with thumbs up emoji

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
tomasr8and others added2 commitsMay 25, 2023 21:37
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great to me. Thanks@tomasr8!

@AlexWaygoodAlexWaygood merged commitfea8632 intopython:mainMay 25, 2023
@tomasr8tomasr8 deleted the typeddict-kwargs-removal branchMay 25, 2023 20:18
@tomasr8
Copy link
MemberAuthor

Thanks for the reviews!

AlexWaygood and JelleZijlstra reacted with rocket emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@tomasr8@AlexWaygood@JelleZijlstra@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp