Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104873: Add typing.get_protocol_members and typing.is_protocol#104878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 14 commits intopython:mainfromJelleZijlstra:protoattrs
Jun 14, 2023

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMay 24, 2023•
edited by github-actionsbot
Loading

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@JelleZijlstraJelleZijlstra changed the titlegh-104873: Add typing.get_protocol_membersgh-104873: Add typing.get_protocol_members and typing.is_protocolMay 24, 2023
@JelleZijlstra
Copy link
MemberAuthor

I didn't expect the Spanish inquisition!

AlexWaygood reacted with heart emoji

@bedevere-bot
Copy link

Nobody expects the Spanish Inquisition!

@AlexWaygood: please review the changes made to this pull request.

JelleZijlstraand others added2 commitsMay 24, 2023 13:10
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, but I'd love to get a third opinion from@gvanrossum or@Fidget-Spinner on the API, if possible

@JelleZijlstra
Copy link
MemberAuthor

FYI I also just emailed typing-sig about this to ask for feedback.

AlexWaygood reacted with thumbs up emoji

@JelleZijlstra
Copy link
MemberAuthor

Nobody spoke up against this on typing-sig, time to merge?

JelleZijlstraand others added3 commitsJune 13, 2023 19:37
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Time to merge, in my opinion!

@JelleZijlstraJelleZijlstra merged commitfc8037d intopython:mainJun 14, 2023
@JelleZijlstraJelleZijlstra deleted the protoattrs branchJune 14, 2023 12:43
@JelleZijlstraJelleZijlstra restored the protoattrs branchSeptember 10, 2024 23:37
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@gvanrossumgvanrossumAwaiting requested review from gvanrossum

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@JelleZijlstra@bedevere-bot@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp