Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104773: PEP 594: Remove the chunk module#104868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 1 commit intopython:mainfromvstinner:remove_chunk
May 25, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMay 24, 2023•
edited by github-actionsbot
Loading

Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Let's also removeDoc/library/chunk.rst fromDoc/tools/.nitignore

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@vstinner
Copy link
MemberAuthor

Let's also remove Doc/library/chunk.rst from Doc/tools/.nitignore

Oh, I missed that one: it's now removed.

@vstinner
Copy link
MemberAuthor

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@hugovk: please review the changes made to this pull request.

@bedevere-botbedevere-bot requested a review fromhugovkMay 24, 2023 15:16
Copy link
Member

@hugovkhugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks!

@vstinner
Copy link
MemberAuthor

Oh. test_aifc uses thechunk module. It should be removed before the chunk module can be removed:

test test_aifc crashed -- Traceback (most recent call last):(...)  File "D:\a\cpython\cpython\Lib\aifc.py", line 260, in <module>    from chunk import ChunkModuleNotFoundError: No module named 'chunk'

@vstinnervstinner marked this pull request as draftMay 24, 2023 15:43
auto-merge was automatically disabledMay 24, 2023 15:43

Pull request was converted to draft

@vstinnervstinner changed the titlegh-104773: PEP 594: Remove the chunk moduleWIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk moduleMay 24, 2023
@vstinnervstinner changed the titleWIP (aifc must be removed first): gh-104773: PEP 594: Remove the chunk modulegh-104773: PEP 594: Remove the chunk moduleMay 25, 2023
@vstinnervstinner marked this pull request as ready for reviewMay 25, 2023 16:02
@vstinner
Copy link
MemberAuthor

PR rebased on main, now that the aifc module has been removed.

@vstinnervstinnerenabled auto-merge (squash)May 25, 2023 16:09
@vstinnervstinner merged commit77d7ec5 intopython:mainMay 25, 2023
@vstinnervstinner deleted the remove_chunk branchMay 25, 2023 16:28
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@vstinner@bedevere-bot@hugovk
[8]ページ先頭
©2009-2025 Movatter.jp