Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-102856: Update "Formatted string literals" docs section after PEP701#104861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I think we need to fix also the "grammar" that is included here and substitute that for the PEG grammar |
I mean this one |
Not sure about that. The existing grammar feels easier to read. Since the purpose of this is to give an overview of what can go into an f-string, I don't think we should over-complicate stuff with |
Hummmm IIRC that grammar is slightly incorrect or it was missing some details. Check it out and if you are happy with it then let's keep it |
I briefly compared it with our version in the PEG and it seems okay to me. If you're also okay with it, we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Great work!
Thanks@lysnikolaou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
…r PEP701 (pythonGH-104861)(cherry picked from commit8e5b3b9)Co-authored-by: Lysandros Nikolaou <lisandrosnik@gmail.com>
bedevere-bot commentedMay 24, 2023
GH-104865 is a backport of this pull request to the3.12 branch. |
Uh oh!
There was an error while loading.Please reload this page.
📚 Documentation preview 📚:https://cpython-previews--104861.org.readthedocs.build/