Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-104773: PEP 594: Remove the pipes module#104848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vstinner merged 2 commits intopython:mainfromvstinner:remove_pipes
May 24, 2023

Conversation

vstinner
Copy link
Member

@vstinnervstinner commentedMay 24, 2023
edited by github-actionsbot
Loading

@vstinnervstinner changed the titlegh-104773: PEP 594: Remove pipes modulegh-104773: PEP 594: Remove the pipes moduleMay 24, 2023
@hugovk
Copy link
Member

The doctest failure is unrelated, here's a PR to fix it:#104852

@vstinner
Copy link
MemberAuthor

@AlexWaygood: Why did you merged the branch 'main' into remove_pipes? I created this PR 49 minutes ago. Do you expect regressions since main changed in the meanwhile? I was awaiting CI tests to complete, and with this merge I have to wait 30 minutes again :-(

@hugovk
Copy link
Member

I expect it's to include the doctest fix#104852 frommain, so we can get a nice clean (green) slate here.

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

AlexWaygood commentedMay 24, 2023
edited
Loading

@vstinner sorry if I was unhelpful. The doctest CI check was failing on this PR for an unrelated reason; after Hugo merged his fix for the doctest failure intomain, I thought I could retrigger the check for you here by mergingmain into this PR branch. But, since it wasn't a "required" check, you probably could have merged the PR anyway, despite the CI check being red. My bad — sorry again :-)

@hugovk
Copy link
Member

By the way, we've now made available GitHub's "Enable auto-merge" feature for this repo, so this could be a good opportunity to give it a spin:

https://devguide.python.org/getting-started/git-boot-camp/#accepting-and-merging-a-pull-request

@vstinner
Copy link
MemberAuthor

The doctest CI check was failing on this PR

Oh, I didn't see. In that case, thank you :-) I was just surprised to see a merge without any explanation.

AlexWaygood reacted with thumbs up emoji

@AlexWaygood
Copy link
Member

I was just surprised to see a merge without any explanation.

Apologies — I'll explain my actions next time 😄

vstinner reacted with thumbs up emoji

@vstinnervstinner merged commita4b7e9d intopython:mainMay 24, 2023
@vstinnervstinner deleted the remove_pipes branchMay 24, 2023 11:11
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hugovkhugovkhugovk approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@vstinner@hugovk@AlexWaygood@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp