Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104825: Remove implicit newline in the line attribute in tokens emitted in the tokenize module#104846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pablogsal merged 3 commits intopython:mainfrompablogsal:main
May 24, 2023

Conversation

pablogsal
Copy link
Member

@pablogsalpablogsal commentedMay 24, 2023•
edited by bedevere-bot
Loading

@pablogsal
Copy link
MemberAuthor

CC:@mgmacias95

Copy link
Member

@lysnikolaoulysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@pablogsalpablogsal merged commitc8cf9b4 intopython:mainMay 24, 2023
@pablogsalpablogsal added the needs backport to 3.12only security fixes labelMay 24, 2023
@miss-islington
Copy link
Contributor

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@pablogsal, I could not cleanly backport this to3.12 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker c8cf9b42eb2bfbd4c3e708ec28d32430248a1d7a 3.12

pablogsal added a commit to pablogsal/cpython that referenced this pull requestMay 24, 2023
… in tokens emitted in the tokenize module (pythonGH-104846).(cherry picked from commitc8cf9b4)Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot
Copy link

GH-104850 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 24, 2023
pablogsal added a commit that referenced this pull requestMay 24, 2023
…kens emitted in the tokenize module (GH-104846). (#104850)(cherry picked from commitc8cf9b4)
@terryjreedyterryjreedy added the needs backport to 3.11only security fixes labelMay 24, 2023
@miss-islington
Copy link
Contributor

Thanks@pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry,@pablogsal, I could not cleanly backport this to3.11 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker c8cf9b42eb2bfbd4c3e708ec28d32430248a1d7a 3.11

@terryjreedy
Copy link
Member

terryjreedy commentedMay 24, 2023•
edited
Loading

I backported the test to 3.11 so I thought it would need this fix, but now I realize that 3.11 still has the old tokenizer, for which the patch is correct as it (tested). Sorry for the noise. But see#104850 (comment)

pablogsal reacted with thumbs up emojipablogsal reacted with heart emoji

@ZeroIntensityZeroIntensity removed the needs backport to 3.11only security fixes labelFeb 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@lysnikolaoulysnikolaoulysnikolaou approved these changes

@terryjreedyterryjreedyAwaiting requested review from terryjreedyterryjreedy is a code owner

Assignees

@pablogsalpablogsal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@pablogsal@miss-islington@bedevere-bot@terryjreedy@lysnikolaou@ZeroIntensity
[8]ページ先頭
©2009-2025 Movatter.jp