Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
[3.12] Fix test_importlib.test_side_effect_import() (GH-104840)#104842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Wait until the thread spawn by the import completes to avoid danglingthreads. With this fix, the following command no longer fails:./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20(cherry picked from commit4269509)Co-authored-by: Victor Stinner <vstinner@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, good bot.
@vstinner did you mean to leave this open after approving, or did you forget the auto-merge label? |
I'm not used to the new workflow. I merged this backport manually. |
Wait until the thread spawn by the import completes to avoid dangling
threads. With this fix, the following command no longer fails:
./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20
(cherry picked from commit4269509)
Co-authored-by: Victor Stinnervstinner@python.org