Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
Fix test_importlib.test_side_effect_import()#104840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Wait until the thread spawn by the import completes to avoid danglingthreads. With this fix, the following command no longer fails:./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20
gpshead approved these changesMay 24, 2023
Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2023
Wait until the thread spawn by the import completes to avoid danglingthreads. With this fix, the following command no longer fails:./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20(cherry picked from commit4269509)Co-authored-by: Victor Stinner <vstinner@python.org>
bedevere-bot commentedMay 24, 2023
GH-104842 is a backport of this pull request to the3.12 branch. |
bedevere-bot commentedMay 24, 2023
GH-104843 is a backport of this pull request to the3.11 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2023
Wait until the thread spawn by the import completes to avoid danglingthreads. With this fix, the following command no longer fails:./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20(cherry picked from commit4269509)Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull requestMay 25, 2023
)Fix test_importlib.test_side_effect_import() (GH-104840)Wait until the thread spawn by the import completes to avoid danglingthreads. With this fix, the following command no longer fails:./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20(cherry picked from commit4269509)Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner added a commit that referenced this pull requestMay 25, 2023
)Fix test_importlib.test_side_effect_import() (GH-104840)Wait until the thread spawn by the import completes to avoid danglingthreads. With this fix, the following command no longer fails:./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20(cherry picked from commit4269509)Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait until the thread spawn by the import completes to avoid dangling threads. With this fix, the following command no longer fails:
./python -m test --fail-env-changed test_importlib -m test_side_effect_import -F -j20