Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-104835: Remove unittest's deprecated getTestCaseNames, makeSuite, findTestCases#104836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
JelleZijlstra approved these changesMay 24, 2023
markmentovai added a commit to markmentovai/pyftdi that referenced this pull requestNov 4, 2024
```ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.Hint: make sure your test modules/packages have valid Python names.Traceback:…/lib/python3.13/importlib/__init__.py:88: in import_module return _bootstrap._gcd_import(name[level:], package, level)pyftdi/tests/toolsimport.py:16: in <module> from unittest import TestCase, TestSuite, makeSuite, main as ut_mainE ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)```python/cpython#104835python/cpython#104836python/cpython@b1cb30ehttps://docs.python.org/3/whatsnew/3.13.html#unittest
eblot pushed a commit to eblot/pyftdi that referenced this pull requestNov 19, 2024
```ImportError while importing test module '…/pyftdi/pyftdi/tests/toolsimport.py'.Hint: make sure your test modules/packages have valid Python names.Traceback:…/lib/python3.13/importlib/__init__.py:88: in import_module return _bootstrap._gcd_import(name[level:], package, level)pyftdi/tests/toolsimport.py:16: in <module> from unittest import TestCase, TestSuite, makeSuite, main as ut_mainE ImportError: cannot import name 'makeSuite' from 'unittest' (…/lib/python3.13/unittest/__init__.py)```python/cpython#104835python/cpython#104836python/cpython@b1cb30ehttps://docs.python.org/3/whatsnew/3.13.html#unittest
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#104835.
Remove
unittest'sfindTestCases,makeSuiteandgetTestCaseNames, deprecated in Python 3.11 ingh-50096 and scheduled for removal in 3.13.Use
unittest.TestLoadermethods instead:unittest.TestLoader.loadTestsFromModuleunittest.TestLoader.loadTestsFromTestCaseunittest.TestLoader.getTestCaseNames📚 Documentation preview 📚:https://cpython-previews--104836.org.readthedocs.build/