Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104372: use == -1 before PyErr_Occurred#104831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 1 commit intopython:mainfromgpshead:gh-104372-fdEQ-1
May 24, 2023

Conversation

gpshead
Copy link
Member

@gpsheadgpshead commentedMay 24, 2023•
edited by bedevere-bot
Loading

The ideal pattern for this.  (already in the 3.11 backport)
@miss-islington
Copy link
Contributor

Thanks@gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-104833 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2023
The ideal pattern for this.  (already in the 3.11 backport)(cherry picked from commit7f963bf)Co-authored-by: Gregory P. Smith <greg@krypto.org>
gpshead added a commit that referenced this pull requestMay 24, 2023
gh-104372: use == -1 before PyErr_Occurred (GH-104831)The ideal pattern for this.  (already in the 3.11 backport)(cherry picked from commit7f963bf)Co-authored-by: Gregory P. Smith <greg@krypto.org>
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Ubuntu Shared 3.x has failed when building commit7f963bf.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/506/builds/4875) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f963bf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/506/builds/4875

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

442 tests OK.

10 slowest tests:

  • test_tools: 5 min 55 sec
  • test_multiprocessing_spawn: 3 min 46 sec
  • test_math: 3 min 36 sec
  • test_concurrent_futures: 2 min 57 sec
  • test_gdb: 2 min 48 sec
  • test_multiprocessing_forkserver: 1 min 48 sec
  • test_unparse: 1 min 35 sec
  • test_compileall: 1 min 24 sec
  • test_capi: 1 min 21 sec
  • test_multiprocessing_fork: 1 min 15 sec

1 test altered the execution environment:
test_importlib

22 tests skipped:
test.test_asyncio.test_windows_events
test.test_asyncio.test_windows_utils test_devpoll test_idle
test_ioctl test_kqueue test_launcher test_msilib test_nis
test_peg_generator test_startfile test_tcl test_tix test_tkinter
test_ttk test_ttk_textonly test_turtle test_winconsoleio
test_winreg test_winsound test_wmi test_zipfile64

Total duration: 27 min 57 sec

Click to see traceback logs
remote:Enumerating objects: 7, done.remote:Counting objects:  14% (1/7)remote:Counting objects:  28% (2/7)remote:Counting objects:  42% (3/7)remote:Counting objects:  57% (4/7)remote:Counting objects:  71% (5/7)remote:Counting objects:  85% (6/7)remote:Counting objects: 100% (7/7)remote:Counting objects: 100% (7/7), done.remote:Compressing objects: 100% (1/1)remote:Compressing objects: 100% (1/1), done.remote:Total 4 (delta 3), reused 4 (delta 3), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '7f963bfc79a515dc9822ebddbfb1b5927d2dda09'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 7f963bfc79 gh-104372: use == -1 before PyErr_Occurred (#104831)Switched to and reset branch 'main'./configure:line 8401: -reorder-blocks=ext-tsp: command not foundconfigure:WARNING: pkg-config is missing. Some dependencies may not be detected correctly.make:*** [Makefile:2011: buildbottest] Error 3

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Arch Linux TraceRefs 3.x has failed when building commit7f963bf.

What do you need to do:

  1. Don't panic.
  2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/484/builds/3377) and take a look at the build logs.
  4. Check if the failure is related to this commit (7f963bf) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/484/builds/3377

Failed tests:

  • test__xxsubinterpreters

Summary of the results of the build (if available):

==

Click to see traceback logs
remote:Enumerating objects: 4, done.remote:Counting objects:  25% (1/4)remote:Counting objects:  50% (2/4)remote:Counting objects:  75% (3/4)remote:Counting objects: 100% (4/4)remote:Counting objects: 100% (4/4), done.remote:Compressing objects:  33% (1/3)remote:Compressing objects:  66% (2/3)remote:Compressing objects: 100% (3/3)remote:Compressing objects: 100% (3/3), done.remote:Total 4 (delta 1), reused 3 (delta 1), pack-reused 0From https://github.com/python/cpython * branch                  main       -> FETCH_HEADNote:switching to '7f963bfc79a515dc9822ebddbfb1b5927d2dda09'.You are in 'detached HEAD' state. You can look around, make experimentalchanges and commit them, and you can discard any commits you make in thisstate without impacting any branches by switching back to a branch.If you want to create a new branch to retain commits you create, you maydo so (now or later) by using -c with the switch command. Example:  git switch -c <new-branch-name>Or undo this operation with:  git switch -Turn off this advice by setting config variable advice.detachedHead to falseHEAD is now at 7f963bfc79 gh-104372: use == -1 before PyErr_Occurred (#104831)Switched to and reset branch 'main'./configure:line 8401: -reorder-blocks=ext-tsp: command not foundObjects/object.c:2211: _Py_ForgetReference: Assertion failed: invalid object chainEnable tracemalloc to get the memory block allocation tracebackobject address  : 0x7f97d5d15300object refcount : 0object type     : 0x55ffd0d0d8c0object type name: bytesobject repr     : <refcnt 0 at 0x7f97d5d15300>Fatal Python error: _PyObject_AssertFailed: _PyObject_AssertFailedPython runtime state: initializedCurrent thread 0x00007f97e816a740 (most recent call first):  <no Python frame>Extension modules: _xxsubinterpreters (total: 1)Debug memory block at address p=0x7f97e8091e30: API '�'18302063728033390045bytes originally requested    The7 padbytes at p-7 arenotall FORBIDDENBYTE (0xfd):        at p-7:0xdd***OUCH        at p-6:0xdd***OUCH        at p-5:0xdd***OUCH        at p-4:0xdd***OUCH        at p-3:0xdd***OUCH        at p-2:0xdd***OUCH        at p-1:0xdd***OUCH    Because memoryis corrupted at the start, the count ofbytes requested       may be bogus,and checking the trailing padbytes may segfault.    The8 padbytes at tail=0xfdfe7d95e606fc0d are Fatal Python error: Segmentation faultCurrent thread 0x00007f97e816a740 (most recent call first):  <no Python frame>Extension modules: _testcapi, _xxsubinterpreters (total: 2)make:*** [Makefile:2015: buildbottest] Segmentation fault (core dumped)Cannot open file '/buildbot/buildarea/3.x.pablogsal-arch-x86_64/build/test-results.xml' for upload

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees

@gpsheadgpshead

Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@gpshead@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp