Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-89812: Clean up pathlib tests.#104829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 4 commits intopython:mainfrombarneygale:simplify-pathlib-tests
Jun 14, 2023

Conversation

barneygale
Copy link
Contributor

@barneygalebarneygale commentedMay 24, 2023•
edited by bedevere-bot
Loading

MergePurePathTest into_BasePurePathTest, andPathTest into_BasePathTest. No change of coverage.

Merge `PurePathTest` into `_BasePurePathTest`, and `PathTest` into`_BasePathTest`.
@barneygale
Copy link
ContributorAuthor

Note that the_BasePurePathTest and_BasePathTest classes reflect a time long ago when pathlib hadpathlib._BasePurePath andpathlib._BasePath classes. These haven't existed since pathlib was an independent package. We may re-introduce them in future (see#104810), but they will look rather different!

@barneygalebarneygale changed the titleClean up pathlib tests.GH-89812: Clean up pathlib tests.Jun 3, 2023
@bedevere-botbedevere-bot mentioned this pull requestJun 3, 2023
@ambv
Copy link
Contributor

This depends onGH-105744.

barneygale reacted with thumbs up emoji

@barneygalebarneygale requested a review fromambvJune 13, 2023 20:45
@ambv
Copy link
Contributor

I currently don't have a Windows box to test the coverage with, but I tested on macOS and Linux and this looks good to me. Let's go for it! Thanks for the cleanup, Barney! ✨ 🍰 ✨

barneygale reacted with thumbs up emoji

@ambvambv merged commitdab5a3e intopython:mainJun 14, 2023
@ambv
Copy link
Contributor

(If you're curious to check on Windows, the guide is good:https://devguide.python.org/testing/coverage/)

barneygale reacted with thumbs up emoji

@barneygale
Copy link
ContributorAuthor

Thank you for the review, Łukasz!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ambvambvAwaiting requested review from ambv

Assignees
No one assigned
Labels
skip newstestsTests in the Lib/test dirtopic-pathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@barneygale@ambv@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp