Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11#104816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
hugovk merged 8 commits intopython:mainfromhugovk:rm-webbrowser-MacOSX
May 26, 2023

Conversation

hugovk
Copy link
Member

@hugovkhugovk commentedMay 23, 2023•
edited
Loading

Closes#104804.

Removewebbrowser.MacOSX class, deprecated in Python 3.11 ingh-86421.

Also fix Sphinx warnings inwebbrowser.rst (helpsgh-101100):

  • I don't think we need to defineenvvars forPATH orKDEDIR

  • We could define.. envvar:: BROWSER right before the first mention, but it looks a little out of place having aBROWSER before the third paragraph. Thoughts?

  • I also don't think we need to define the dozen or soMozilla,Opera etc. classes. They're listed in the table that shows which type name corresponds to each class, and some of them have extra details like how they're instantiated (Mozilla('mozilla'),GenericBrowser('lynx')), so plain literal text makes sense here. Repeating each class below would be a lot of duplication for little benefit, especially for this rather short page.

  • https://cpython-previews--104816.org.readthedocs.build/en/104816/library/webbrowser.html

📚 Documentation preview 📚:https://cpython-previews--104816.org.readthedocs.build/

CAM-Gerlach reacted with thumbs up emoji
@hugovkhugovk changed the titleRemove webbrowser.MacOSX class, deprecated in Python 3.11gh-104804: Remove webbrowser.MacOSX class, deprecated in Python 3.11May 23, 2023
@serhiy-storchaka
Copy link
Member

Would not be better to split this PR on two? One for removing, and other for tidying?

@CAM-GerlachCAM-Gerlach added the stdlibPython modules in the Lib dir labelMay 23, 2023
@hugovk
Copy link
MemberAuthor

I can do, but they are intertwined: this bit is removed, which otherwise has warnings that would need fixing, or waiting for part 1 to be merged:

..deprecated-removed::3.11 3.13:class:`MacOSX` is deprecated, use:class:`MacOSXOSAScript` instead.

Seems easier to do both at once. But either way is fine for me :)

Copy link
Member

@CAM-GerlachCAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I had a handful of doc-related suggestions. Otherwise, the core change looks good. The removal of the:class: syntax for things that are really code snippits (and not formally documented anyway) makes sense, as does silencing warnings for env vars not explicitly defined by or primarily/exclusively used by Python itself.

Ideally it would be nice to split it into two PRs as@serhiy-storchaka , but as a practical matter given they interlinked, maybe not worth the extra effort.

@hugovkhugovk added the 3.13bugs and security fixes labelMay 25, 2023
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM if you fix the typo in the NEWS entry.

Co-authored-by: Victor Stinner <vstinner@python.org>
@hugovkhugovk merged commit5ab4bc0 intopython:mainMay 26, 2023
@hugovkhugovk deleted the rm-webbrowser-MacOSX branchMay 26, 2023 13:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@CAM-GerlachCAM-GerlachCAM-Gerlach left review comments

@vstinnervstinnervstinner approved these changes

Assignees
No one assigned
Labels
3.13bugs and security fixesstdlibPython modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove deprecated webbrowser.MacOSX class
5 participants
@hugovk@serhiy-storchaka@vstinner@CAM-Gerlach@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp