Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-99108: Refresh HACL*#104808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gpshead merged 3 commits intopython:mainfrommsprotz:protz_hacl_refresh
May 24, 2023
Merged

Conversation

msprotz
Copy link
Contributor

@msprotzmsprotz commentedMay 23, 2023•
edited by bedevere-bot
Loading

There have been a few important upstream changes in HACL* that I'd like to bring in, and hopefully backport to the 3.12 branch.

FYI SHA3 is also being integrated into NSS as we speak, hence the active upstream development on making things better.

gpshead reacted with thumbs up emoji
@msprotz
Copy link
ContributorAuthor

@gpshead let me know if you'd like a NEWS entry or not. Thanks!

@gpsheadgpshead added the needs backport to 3.12only security fixes labelMay 24, 2023
@gpshead
Copy link
Member

I'd still add a NEWS entry as it is an observable change and a potential bugfix: Something likeRefresh our new HACL* built-in :mod:`hashlib` code from upstream. Built-in SHA2 should be faster and an issue with SHA3 on 32-bit platforms is fixed.

msprotz reacted with thumbs up emoji

@gpsheadgpshead self-assigned thisMay 24, 2023
@gpsheadgpshead merged commit160321e intopython:mainMay 24, 2023
@miss-islington
Copy link
Contributor

Thanks@msprotz for the PR, and@gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2023
Refresh HACL* from upstream to improve SHA2 performance and fix a 32-bit issue in SHA3.(cherry picked from commit160321e)Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
@bedevere-bot
Copy link

GH-104893 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 24, 2023
gpshead pushed a commit that referenced this pull requestMay 24, 2023
gh-99108: Refresh HACL* (GH-104808)Refresh HACL* from upstream to improve SHA2 performance and fix a 32-bit issue in SHA3.(cherry picked from commit160321e)Co-authored-by: Jonathan Protzenko <protz@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gpsheadgpsheadgpshead approved these changes

@tirantiranAwaiting requested review from tirantiran is a code owner

Assignees

@gpsheadgpshead

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@msprotz@gpshead@miss-islington@bedevere-bot
[8]ページ先頭
©2009-2025 Movatter.jp