Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-104770: Let generator.close() return value#104771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
9 commits Select commitHold shift + click to select a range
347d478 let generator.close() return value
ntessorecd94e7f add NEWS.d entry
ntessoref134f7f move NEWS.d entry
ntessore2175dc2 use PyErr_GetRaisedException() and improve wording of docs
ntessoreecfaa1f Apply suggestions from code review
ntessore678332a use _PyGen_FetchStopIterationValue()
ntessore206dcd0 simplify return logic
ntessorec0c4b51 apply changes to documentation
ntessored51a4ca Merge remote-tracking branch 'origin/main' into generator-close-return
ntessoreFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
use _PyGen_FetchStopIterationValue()
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit678332a88317ef2436b83e47bd736ddbb48247c4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -409,11 +409,10 @@ gen_close(PyGenObject *gen, PyObject *args) | ||
| return NULL; | ||
| } | ||
| if (PyErr_ExceptionMatches(PyExc_StopIteration)) { | ||
ntessore marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| /* fetch the value of the StopIteration instance being handled; | ||
| * this clears the error indicator */ | ||
| PyObject *value; | ||
| _PyGen_FetchStopIterationValue(&value); | ||
| return value; | ||
| } | ||
| if (PyErr_ExceptionMatches(PyExc_GeneratorExit)) { | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.