Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-104719: IDLE - test existence of all tokenize references.#104767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 14 commits intopython:mainfromterryjreedy:toktest
May 24, 2023

Conversation

terryjreedy
Copy link
Member

@terryjreedyterryjreedy commentedMay 22, 2023•
edited
Loading

This was prompted when (temporary) removal of tokenize.tabsize broke IDLE without a CI failure.
Class editor.IndentSearcher contains all editor references to the tokenize module.
The 2 iomenu references cover those in pyshell, run, and runscript also.

terryjreedyand others added2 commitsMay 23, 2023 01:06
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@terryjreedyterryjreedy added needs backport to 3.11only security fixes needs backport to 3.12only security fixes and removed topic-IDLE labelsMay 23, 2023
@terryjreedyterryjreedyenabled auto-merge (squash)May 23, 2023 21:34
@terryjreedy
Copy link
MemberAuthor

@Yhg1s Can you as RM merge this? Address sanitizer had failed 4 times in a row because test_hashlib, test_importlib, and test_threading (X3) have altered the environment. Details on discord core-workflow. (Will rerun again

@terryjreedyterryjreedy merged commite561c09 intopython:mainMay 24, 2023
@miss-islington
Copy link
Contributor

Thanks@terryjreedy for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2023
…ythonGH-104767)Class editor.IndentSearcher contains all editor references to tokenize module.Module io tokenize reference cover those other modules.(cherry picked from commite561c09)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

GH-104844 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 24, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 24, 2023
…ythonGH-104767)Class editor.IndentSearcher contains all editor references to tokenize module.Module io tokenize reference cover those other modules.(cherry picked from commite561c09)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

GH-104845 is a backport of this pull request to the3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11only security fixes labelMay 24, 2023
terryjreedy added a commit that referenced this pull requestMay 24, 2023
…H-104767) (#104844)gh-104719: IDLE - test existence of all tokenize references. (GH-104767)Class editor.IndentSearcher contains all editor references to tokenize module.Module io tokenize reference cover those other modules.(cherry picked from commite561c09)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
terryjreedy added a commit that referenced this pull requestMay 24, 2023
…H-104767) (#104845)gh-104719: IDLE - test existence of all tokenize references. (GH-104767)Class editor.IndentSearcher contains all editor references to tokenize module.Module io tokenize reference cover those other modules.(cherry picked from commite561c09)Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra
Copy link
Member

The buildbot failure might be a bad interaction with#104846 which@pablogsal merged earlier.

@JelleZijlstra
Copy link
Member

Oh, seems like Pablo already fixed this in his PR?

@terryjreedy
Copy link
MemberAuthor

terryjreedy commentedMay 24, 2023•
edited
Loading

From#104880 message. "Order of events:
Terry automerged new idlelib test into main.
Ms. I. made a 3.12 backport; tests passed.
Pablo merged the tokenize change with idlelib test fix into main. Pablo merged a 3.12 backport without the idle test fix as the backport of the latter had not yet been been merged. Terry merged the idlelib test backport. The new test failed on at least 4 3.12 buildbots because of the tokenize change. This PR backports the now needed idlelib test fix."

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments

Assignees

@terryjreedyterryjreedy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@terryjreedy@miss-islington@bedevere-bot@JelleZijlstra@Yhg1s@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp