Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Comments

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes#104752

Merged
corona10 merged 2 commits intopython:mainfrom
corona10:gh-101282-fix-macos-other
May 24, 2023
Merged

gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes#104752
corona10 merged 2 commits intopython:mainfrom
corona10:gh-101282-fix-macos-other

Conversation

@corona10
Copy link
Member

@corona10corona10 commentedMay 22, 2023•
edited
Loading

Without this revert on macOS:

checking for --enable-bolt... nochecking BOLT_INSTRUMENT_FLAGS...checking BOLT_APPLY_FLAGS... ./configure: line 8401: -reorder-blocks=ext-tsp: command not found

With this revert on macOS:

checking BOLT_INSTRUMENT_FLAGS...checking BOLT_APPLY_FLAGS... -update-debug-sections -reorder-blocks=ext-tsp -reorder-functions=hfsort+ -split-functions -icf=1 -inline-all -split-eh -reorder-functions-use-hot-size -peepholes=none -jump-tables=aggressive -inline-ap -indirect-call-promotion=all -dyno-stats -use-gnu-stack -frame-opt=hot

@corona10
Copy link
MemberAuthor

cc@indygreg Not decided yet which PR will be merged

@corona10corona10 added the needs backport to 3.12only security fixes labelMay 23, 2023
@erlend-aasland
Copy link
Contributor

Dong-hee: I'll take a look tonight (CET).

corona10 reacted with heart emoji

Copy link
Contributor

@erlend-aaslanderlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment:I have made the requested changes; please review again.

@erlend-aaslanderlend-aasland changed the titlegh-101282: Fix M4 style for BOLT configurationgh-101282: Enclose BOLT_APPLY_FLAGS value in double quotesMay 24, 2023
@erlend-aasland
Copy link
Contributor

Thanks!

@corona10corona10 merged commitc437851 intopython:mainMay 24, 2023
@miss-islington
Copy link
Contributor

Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry@corona10, I had trouble checking out the3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport usingcherry_picker on the command line.
cherry_picker c43785192c97698a0217a680b30baae22106ed3e 3.12

corona10 added a commit to corona10/cpython that referenced this pull requestMay 24, 2023
…es (pythongh-104752)(cherry picked from commitc437851)Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot
Copy link

GH-104853 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 24, 2023
@bedevere-bot
Copy link

GH-104853 is a backport of this pull request to the3.12 branch.

@erlend-aasland
Copy link
Contributor

I forgot to ask the obvious question: did you verify that the warning disappeared?

corona10 added a commit that referenced this pull requestMay 24, 2023
gh-104853)[3.12]gh-101282: Enclose BOLT_APPLY_FLAGS value in double quotes (gh-104752)(cherry picked from commitc437851)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@erlend-aaslanderlend-aaslanderlend-aasland approved these changes

@ned-deilyned-deilyAwaiting requested review from ned-deily

Assignees

@corona10corona10

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@corona10@erlend-aasland@bedevere-bot@miss-islington@Yhg1s
[8]ページ先頭
©2009-2026 Movatter.jp