Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
gh-96471: Add threading queue shutdown#104750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
gvanrossum merged 13 commits intopython:mainfromEpicWink:threading-queue-shutdown-immediate-consumeFeb 10, 2024
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
13 commits Select commitHold shift + click to select a range
cd8ceaf
Add threading queue shutdown
EpicWink9c2971b
Fix queue shutdown
YvesDup089eb96
📜🤖 Added by blurb_it.
blurb-it[bot]ca118d7
Shut-down immediate consumes queue
EpicWink88f918d
Update test typing
EpicWinkab8d975
Remove queue-size tasks instead of setting to zero
EpicWinkf279f5c
Merge remote-tracking branch 'upstream/main' into threading-queue-shu…
EpicWink971f699
Improve doc wording, reference methods
EpicWinkddfb8c2
Reference method in news entry
EpicWink3570bd8
Remove typing in test script
EpicWink9072c6f
Fix join after task-done with no get
EpicWinke0927aa
More explicitly update 'q.unfinished_tasks'
EpicWink22adada
Add what's new entry
EpicWinkFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
38 changes: 38 additions & 0 deletionsDoc/library/queue.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletionsDoc/whatsnew/3.13.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
50 changes: 50 additions & 0 deletionsLib/queue.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -25,6 +25,10 @@ class Full(Exception): | ||
pass | ||
class ShutDown(Exception): | ||
'''Raised when put/get with shut-down queue.''' | ||
EpicWink marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
class Queue: | ||
'''Create a queue object with a given maximum size. | ||
@@ -54,6 +58,9 @@ def __init__(self, maxsize=0): | ||
self.all_tasks_done = threading.Condition(self.mutex) | ||
self.unfinished_tasks = 0 | ||
# Queue shutdown state | ||
self.is_shutdown = False | ||
def task_done(self): | ||
'''Indicate that a formerly enqueued task is complete. | ||
@@ -67,6 +74,8 @@ def task_done(self): | ||
Raises a ValueError if called more times than there were items | ||
placed in the queue. | ||
Raises ShutDown if the queue has been shut down immediately. | ||
''' | ||
with self.all_tasks_done: | ||
unfinished = self.unfinished_tasks - 1 | ||
@@ -84,6 +93,8 @@ def join(self): | ||
to indicate the item was retrieved and all work on it is complete. | ||
When the count of unfinished tasks drops to zero, join() unblocks. | ||
Raises ShutDown if the queue has been shut down immediately. | ||
''' | ||
with self.all_tasks_done: | ||
while self.unfinished_tasks: | ||
@@ -129,15 +140,21 @@ def put(self, item, block=True, timeout=None): | ||
Otherwise ('block' is false), put an item on the queue if a free slot | ||
is immediately available, else raise the Full exception ('timeout' | ||
is ignored in that case). | ||
Raises ShutDown if the queue has been shut down. | ||
''' | ||
with self.not_full: | ||
if self.is_shutdown: | ||
raise ShutDown | ||
if self.maxsize > 0: | ||
if not block: | ||
if self._qsize() >= self.maxsize: | ||
raise Full | ||
elif timeout is None: | ||
while self._qsize() >= self.maxsize: | ||
self.not_full.wait() | ||
if self.is_shutdown: | ||
raise ShutDown | ||
elif timeout < 0: | ||
raise ValueError("'timeout' must be a non-negative number") | ||
else: | ||
@@ -147,6 +164,8 @@ def put(self, item, block=True, timeout=None): | ||
if remaining <= 0.0: | ||
raise Full | ||
self.not_full.wait(remaining) | ||
if self.is_shutdown: | ||
raise ShutDown | ||
self._put(item) | ||
self.unfinished_tasks += 1 | ||
self.not_empty.notify() | ||
@@ -161,14 +180,21 @@ def get(self, block=True, timeout=None): | ||
Otherwise ('block' is false), return an item if one is immediately | ||
available, else raise the Empty exception ('timeout' is ignored | ||
in that case). | ||
Raises ShutDown if the queue has been shut down and is empty, | ||
or if the queue has been shut down immediately. | ||
''' | ||
with self.not_empty: | ||
if self.is_shutdown and not self._qsize(): | ||
raise ShutDown | ||
if not block: | ||
if not self._qsize(): | ||
raise Empty | ||
elif timeout is None: | ||
while not self._qsize(): | ||
self.not_empty.wait() | ||
if self.is_shutdown and not self._qsize(): | ||
raise ShutDown | ||
elif timeout < 0: | ||
raise ValueError("'timeout' must be a non-negative number") | ||
else: | ||
@@ -178,6 +204,8 @@ def get(self, block=True, timeout=None): | ||
if remaining <= 0.0: | ||
raise Empty | ||
self.not_empty.wait(remaining) | ||
if self.is_shutdown and not self._qsize(): | ||
raise ShutDown | ||
item = self._get() | ||
self.not_full.notify() | ||
return item | ||
@@ -198,6 +226,28 @@ def get_nowait(self): | ||
''' | ||
return self.get(block=False) | ||
def shutdown(self, immediate=False): | ||
'''Shut-down the queue, making queue gets and puts raise. | ||
By default, gets will only raise once the queue is empty. Set | ||
'immediate' to True to make gets raise immediately instead. | ||
All blocked callers of put() will be unblocked, and also get() | ||
and join() if 'immediate'. The ShutDown exception is raised. | ||
''' | ||
with self.mutex: | ||
self.is_shutdown = True | ||
if immediate: | ||
n_items = self._qsize() | ||
while self._qsize(): | ||
self._get() | ||
gvanrossum marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
if self.unfinished_tasks > 0: | ||
self.unfinished_tasks -= 1 | ||
self.not_empty.notify_all() | ||
# release all blocked threads in `join()` | ||
self.all_tasks_done.notify_all() | ||
self.not_full.notify_all() | ||
# Override these methods to implement other queue organizations | ||
# (e.g. stack or priority queue). | ||
# These will only be called with appropriate locks held | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.