Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-101291: Avoid using macros with casts in low-level long API.#104742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
iritkatriel merged 1 commit intopython:mainfromfaster-cpython:fix-long-asserts
May 22, 2023

Conversation

markshannon
Copy link
Member

@markshannonmarkshannon commentedMay 22, 2023•
edited
Loading

Stick to inline functions and plainassert to avoid losingconstness.
Fixes C++ compiler warnings.
See#101685 (comment)

@markshannon
Copy link
MemberAuthor

@rwgk can you confirm that this fixes the pybind11 compilation issue?

@rwgk
Copy link

@rwgk can you confirm that this fixes the pybind11 compilation issue?

Yes, confirmed! Thanks for the quick fix!

Building all pybind11 unit tests works again.

For completeness: I'm currently unable to run the full suite of pybind11 unit tests b/o an unrelated problem (#103912 (comment)).

markshannon reacted with thumbs up emoji

@miss-islington
Copy link
Contributor

Thanks@markshannon for the PR, and@iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2023
…pythonGH-104742)(cherry picked from commite295d86)Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-bot
Copy link

GH-104759 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 22, 2023
@JelleZijlstra
Copy link
Member

(Backporting since this fixes compiler warnings from a recent change, so this counts as a bug fix.)

JelleZijlstra pushed a commit that referenced this pull requestMay 23, 2023
GH-104742) (#104759)(cherry picked from commite295d86)Co-authored-by: Mark Shannon <mark@hotpy.org>
@markshannonmarkshannon deleted the fix-long-asserts branchSeptember 26, 2023 12:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@markshannon@rwgk@miss-islington@bedevere-bot@JelleZijlstra@iritkatriel
[8]ページ先頭
©2009-2025 Movatter.jp