Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.7k
gh-104719: Restore Tokenize module constants#104722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
AlexWaygood commentedMay 21, 2023
I was wondering if you could do something like this: _deprecated_objects= {"group":lambda*choices:'('+'|'.join(choices)+')',"any":lambda*choices:group(*choices)+'*',"maybe":lambda*choices:group(*choices)+'?',"Whitespace":r'[ \f\t]*',# etc.} And then at the end of the file have: def__getattr__(name):ifnamein_deprecated_objects:importwarningswarnings._deprecated(f"tokenize.{name}",message=("{name} is untested, undocumented, and deprecated. ""It will be removed in Python {remove}." ),remove=(3,14) )obj=globals()[name]=_deprecated_objects[name]returnobjraiseAttributeError(f"module 'tokenize' has no attribute '{name}'") But I will defer to you and@pablogsal as to whether that's a good idea or not. |
AlexWaygood commentedMay 21, 2023
Looks like this does fix the immediate issue, though -- IDLE is once again able to open |
pablogsal commentedMay 21, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
For the time being, let's just scope this PR to restoring the constants and let's keep the discussion open in the main issue. Also, let's wait until@Yhg1s mentions what he would prefer. Among other things I can imagine an outcome when we promote these to public interface. |
AlexWaygood commentedMay 21, 2023
SGTM. |
Uh oh!
There was an error while loading.Please reload this page.
.pyfiles #104719