Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

GH-104668: Don't callPyOS_* hooks in subinterpreters#104674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
brandtbucher merged 6 commits intopython:mainfrombrandtbucher:global-hooks
May 22, 2023

Conversation

brandtbucher
Copy link
Member

@brandtbucherbrandtbucher commentedMay 19, 2023•
edited by github-actionsbot
Loading

PyOS_InputHook andPyOS_ReadlineFunctionPointer are now only called in the main interpreter.

📚 Documentation preview 📚:https://cpython-previews--104674.org.readthedocs.build/

erlend-aasland reacted with thumbs up emoji
@erlend-aasland
Copy link
Contributor

We should advertise this in What's New as well.

brandtbucher reacted with thumbs up emoji

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@brandtbucherbrandtbucherenabled auto-merge (squash)May 22, 2023 19:25
@brandtbucherbrandtbucher merged commit357bed0 intopython:mainMay 22, 2023
@arhadthedev
Copy link
Member

arhadthedev commentedMay 22, 2023•
edited
Loading

Should we backport it to 3.12?

Edit: I noticed that the label isn't added yet.

@JelleZijlstra
Copy link
Member

@brandtbucher this didn't actually end up in the 3.12 branch. Should we backport it, or is it a new feature that should only go into 3.13?

@brandtbucherbrandtbucher added the needs backport to 3.12only security fixes labelMay 22, 2023
@miss-islington
Copy link
Contributor

Thanks@brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 22, 2023
…-104674)(cherry picked from commit357bed0)Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
@bedevere-bot
Copy link

GH-104760 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 22, 2023
@brandtbucher
Copy link
MemberAuthor

I was waiting for the label. 🙂

JelleZijlstra and arhadthedev reacted with laugh emoji

brandtbucher added a commit that referenced this pull requestMay 23, 2023
GH-104668: Don't call PyOS_* hooks in subinterpreters (GH-104674)(cherry picked from commit357bed0)Co-authored-by: Brandt Bucher <brandtbucher@microsoft.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@pablogsalpablogsalAwaiting requested review from pablogsalpablogsal is a code owner

@lysnikolaoulysnikolaouAwaiting requested review from lysnikolaoulysnikolaou is a code owner

Assignees

@brandtbucherbrandtbucher

Labels
interpreter-core(Objects, Python, Grammar, and Parser dirs)topic-C-APItopic-subinterpreterstopic-tkintertype-bugAn unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@brandtbucher@erlend-aasland@arhadthedev@JelleZijlstra@miss-islington@bedevere-bot@ericsnowcurrently
[8]ページ先頭
©2009-2025 Movatter.jp