Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-103921: Document PEP 695#104642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
JelleZijlstra merged 69 commits intopython:mainfromJelleZijlstra:pep695docs
May 26, 2023
Merged

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstraJelleZijlstra commentedMay 19, 2023•
edited
Loading

@bedevere-botbedevere-bot mentioned this pull requestMay 19, 2023
9 tasks
@bedevere-botbedevere-bot added the docsDocumentation in the Doc dir labelMay 19, 2023
@hugovk
Copy link
Member

You could add this PEP to the release highlights:https://docs.python.org/3.12/whatsnew/3.12.html#summary-release-highlights

JelleZijlstra reacted with thumbs up emoji

Copy link
Member

@AlexWaygoodAlexWaygood left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like us to explicitly state somewhere thattyping.TypeAliasType is not the type oftyping.TypeAlias (and that in fact, they basically don't compose at all). I feel like this will inevitably cause confusion otherwise.

JelleZijlstra reacted with thumbs up emoji
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull requestMay 19, 2023
This allows :keyword:`type` to link to docs for the new `type`statement (being written inpythongh-104642) instead of to this headerin the argparse docs.
JelleZijlstra added a commit that referenced this pull requestMay 19, 2023
This allows :keyword:`type` to link to docs for the new `type`statement (being written ingh-104642) instead of to this headerin the argparse docs.
Copy link
Member

@AlexWaygoodAlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Other than#104642 (comment) and one tiny last nit, this looks fantastic. Thanks for the huge amount of effort here, and for putting up with my many rounds of review!

The latter example's signature is essentially the overloading\n\
of (str, str) -> str and (bytes, bytes) -> bytes. Also note\n\
that if the arguments are instances of some subclass of str,\n\
the return type is still plain str.\n\
\n\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Don't think two line breaks are necessary here

Suggested change
\n\

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks, fixed.

Also thanks for all the thorough reviews! I am going to merge this now so I can stop worrying about conflicts.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yup, it's time :)

@JelleZijlstraJelleZijlstra merged commit060277d intopython:mainMay 26, 2023
@miss-islington
Copy link
Contributor

Thanks@JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

@JelleZijlstraJelleZijlstra deleted the pep695docs branchMay 26, 2023 17:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMay 26, 2023
(cherry picked from commit060277d)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@bedevere-bot
Copy link

GH-104989 is a backport of this pull request to the3.12 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.12only security fixes labelMay 26, 2023
@carljm
Copy link
Member

🎉

@AlexWaygood
Copy link
Member

🥳🚀

JelleZijlstra added a commit that referenced this pull requestMay 26, 2023
(cherry picked from commit060277d)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
JelleZijlstra added a commit to JelleZijlstra/cpython that referenced this pull requestMay 27, 2023
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>.(cherry picked from commit060277d)Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@bedevere-bot
Copy link

GH-105007 is a backport of this pull request to the3.11 branch.


Function and class definitions
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

.. class:: FunctionDef(name, args, body, decorator_list, returns, type_comment)
.. class:: FunctionDef(name,type_params,args, body, decorator_list, returns, type_comment)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just realised thattype_params is in the wrong place here for the AST as it currently exists onmain, wheretype_params is at the end. But probably not worth fixing that until questions about the ABI are resolved in#104974.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also, looks like you might have addedtype_params to the constructor forFunctionDef andClassDef, but notAsyncFunctionDef!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@carljmcarljmcarljm left review comments

@hugovkhugovkhugovk left review comments

@gvanrossumgvanrossumgvanrossum left review comments

@AA-TurnerAA-TurnerAA-Turner left review comments

@Gobot1234Gobot1234Gobot1234 left review comments

@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

@Fidget-SpinnerFidget-SpinnerAwaiting requested review from Fidget-Spinner

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees
No one assigned
Labels
docsDocumentation in the Doc dirskip newstopic-typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

9 participants
@JelleZijlstra@hugovk@miss-islington@bedevere-bot@carljm@AlexWaygood@gvanrossum@AA-Turner@Gobot1234
[8]ページ先頭
©2009-2025 Movatter.jp