NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

[3.11] gh-104615: don't make unsafe swaps in apply_static_swaps (GH-104620).#104636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

carljm merged 1 commit intopython:3.11fromcarljm:backport-0589c6a-3.11

May 19, 2023

Merged

[3.11] gh-104615: don't make unsafe swaps in apply_static_swaps (GH-104620).#104636

carljm merged 1 commit intopython:3.11fromcarljm:backport-0589c6a-3.11

May 19, 2023

Conversation

Copy link

Member

carljm commentedMay 19, 2023•
edited by bedevere-bot
Loading

(cherry picked from commit0589c6a)

Issue:compiler can incorrectly optimize a run of stores to the same name preceded by a SWAP #104615

[3.11]pythongh-104615: don't make unsafe swaps in apply_static_swaps (…

eb83a26

…pythonGH-104620).(cherry picked from commit0589c6a)Co-authored-by: Carl Meyer <carl@oddbird.net>

This was referencedMay 19, 2023

compiler can incorrectly optimize a run of stores to the same name preceded by a SWAP#104615

Closed

gh-104615: don't make unsafe swaps in apply_static_swaps#104620

Merged

carljm marked this pull request as ready for review

May 19, 2023 00:55

carljm requested a review frommarkshannon as acode owner

May 19, 2023 00:55

bedevere-bot added the awaiting core review label

May 19, 2023

carljm requested review frombrandtbucher andiritkatriel

May 19, 2023 00:55

Copy link

MemberAuthor

carljm commentedMay 19, 2023

This required manual backport, but mostly just to eliminate all the stuff from the 3.12 PR that had to do with directly testing the optimizer, since the APIs for that don't exist in 3.11. Also there's noSTORE_FAST_MAYBE_NULL. Still a pretty straightforward backport, but since it was manual I'll wait for review.