NotificationsYou must be signed in to change notification settings
Fork32k
Star67.3k

gh-104600: Make type.__type_params__ writable#104634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

JelleZijlstra merged 5 commits intopython:mainfromJelleZijlstra:typetype

May 19, 2023

Merged

gh-104600: Make type.__type_params__ writable#104634

JelleZijlstra merged 5 commits intopython:mainfromJelleZijlstra:typetype

May 19, 2023

Conversation

Copy link

Member

JelleZijlstra commentedMay 18, 2023•
edited by bedevere-bot
Loading

Issue:function.__type_params__ and type.__type_params__ should be writable #104600

pythongh-104600: Make type.__type_params__ writable

41b9279

JelleZijlstra added the topic-typing label

May 18, 2023

JelleZijlstra requested a review frommarkshannon as acode owner

May 18, 2023 23:16

bedevere-bot added the awaiting core review label

May 18, 2023

bedevere-bot mentioned this pull request

May 18, 2023

function.__type_params__ and type.__type_params__ should be writable#104600

Closed

JelleZijlstra commented

May 18, 2023

View reviewed changes

Objects/typeobject.cShow resolvedHide resolved

be like __doc__, not __annotations__

3f4339d

JelleZijlstra added the skip news label

May 18, 2023

Add tests for generic namedtuples and typeddicts

9b982c4

JelleZijlstra requested review fromgvanrossum,Fidget-Spinner andAlexWaygood ascode owners

May 18, 2023 23:41

Update test

b870cd1

AlexWaygood reviewed

May 19, 2023

View reviewed changes

Lib/test/test_typing.pyShow resolvedHide resolved

Update Lib/test/test_typing.py

0bed086

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>

carljm reviewed

May 19, 2023

View reviewed changes

Lib/test/test_builtin.pyShow resolvedHide resolved

carljm approved these changes

May 19, 2023

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

May 19, 2023

JelleZijlstra merged commit8f1f3b9 intopython:main

May 19, 2023

bedevere-bot removed the awaiting merge label

May 19, 2023

JelleZijlstra deleted the typetype branch

May 19, 2023 16:16

JelleZijlstra mentioned this pull request

May 19, 2023

PEP 695 syntax doesn't work for generic NamedTuples#104616

Closed

carljm added a commit to gsallam/cpython_with_perfmap_apii that referenced this pull request

May 20, 2023

Merge branch 'main' into gsallam/main

ea5965a

* main: (30 commits)pythongh-103987: fix several crashes in mmap module (python#103990)  docs: fix wrong indentation causing rendering error in dis page (python#104661)pythongh-94906: Support multiple steps in math.nextafter (python#103881)pythongh-104472: Skip `test_subprocess.ProcessTestCase.test_empty_env` if ASAN is enabled (python#104667)pythongh-103839: Allow building Tkinter against Tcl 8.7 without external libtommath (pythonGH-103842)pythongh-85984: New additions and improvements to the tty library. (python#101832)pythongh-104659: Consolidate python examples in enum documentation (python#104665)pythongh-92248: Deprecate `type`, `choices`, `metavar` parameters of `argparse.BooleanOptionalAction` (python#103678)pythongh-104645: fix error handling in marshal tests (python#104646)pythongh-104600: Make type.__type_params__ writable (python#104634)pythongh-104602: Add additional test for listcomp with lambda (python#104639)pythongh-104640: Disallow walrus in comprehension within type scopes (python#104641)pythongh-103921: Rename "type" header in argparse docs (python#104654)  Improve readability of `typing._ProtocolMeta.__instancecheck__` (python#104649)pythongh-96522: Fix deadlock in pty.spawn (python#96639)pythonGH-102818: Do not call `PyTraceBack_Here` in sys.settrace trampoline.  (pythonGH-104579)pythonGH-103545: Add macOS specific constants for ``os.setpriority`` to ``os`` (python#104606)pythongh-104623: Update macOS installer to SQLite 3.42.0 (pythonGH-104624)pythongh-104619: never leak comprehension locals to outer locals() (python#104637)pythongh-104602: ensure all cellvars are known up front (python#104603)  ...