Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
gh-104629: Don't skip test_clinic if _testclinic is missing#104630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-104629: Don't skip test_clinic if _testclinic is missing#104630
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Just skip the tests that depend on the _testclinic extension module;we can still run the Python tests.
erlend-aasland commentedMay 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
We should consider backporting to 3.10 as well. This affects the CI. cc.@pablogsal as 3.10 RM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM (assuming the tests pass)
Thanks@erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
bedevere-bot commentedMay 18, 2023
GH-104632 is a backport of this pull request to the3.11 branch. |
…thonGH-104630)Just skip the tests that depend on the _testclinic extension module;we can still run the Python tests.(cherry picked from commit86ee49f)Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
* main:pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)pythongh-104050: Add more type annotations to Argument Clinic (python#104628)pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)pythongh-104549: Set __module__ on TypeAliasType (python#104550)pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)pythongh-104146: Remove unused vars from Argument Clinic (python#104627)pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
Uh oh!
There was an error while loading.Please reload this page.
Just skip the tests that depend on the _testclinic extension module;
we can still run the Python tests.