Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.2k
gh-104050: Add more type annotations to Argument Clinic#104628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
gh-104050: Add more type annotations to Argument Clinic#104628
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- class Class- class Module- class PythonParser- function compute_checksum()- function parse_file()- variable unsupported_special_methods
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
| self.modules: ModuleDict = collections.OrderedDict() | ||
| self.classes: ClassDict = collections.OrderedDict() |
AlexWaygoodMay 18, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Since we're touching these lines anyway: do these need to beOrderedDicts anymore? Regulardicts are guaranteed by the language spec to be ordered on 3.7+ (and clinic now requires 3.10+), and regular dicts are faster thanOrderedDicts.OrderedDicts are mainly there for backwards compatibility these days (they have a few fancy methods that dicts don't have, but I really doubt we need any of them inclinic.py).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could leave this to another PR, though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes, regular dicts should be fine post 3.7.
* main:pythongh-74690: Don't set special protocol attributes on non-protocol subclasses of protocols (python#104622)pythongh-104623: Update Windows installer to use SQLite 3.42.0 (python#104625)pythongh-104050: Add more type annotations to Argument Clinic (python#104628)pythongh-104629: Don't skip test_clinic if _testclinic is missing (python#104630)pythongh-104549: Set __module__ on TypeAliasType (python#104550)pythongh-104050: Improve some typing around `default`s and sentinel values (python#104626)pythongh-104146: Remove unused vars from Argument Clinic (python#104627)pythongh-104615: don't make unsafe swaps in apply_static_swaps (python#104620)pythonGH-104484: Add case_sensitive argument to `pathlib.PurePath.match()` (pythonGH-104565)pythonGH-96803: Document and test new unstable internal frame API functions (pythonGH-104211)pythonGH-104580: Don't cache eval breaker in interpreter (pythonGH-104581)
Uh oh!
There was an error while loading.Please reload this page.