Not sure if converting theunspecified andunknown sentinels to become enum members is entirely worth it; now thatdefault is typed asobject anywhere, the benefits aren't so obvious. I do think it still makes the code alittle cleaner, but you tell me whether you think it's worth the churn@erlend-aasland :)

Not sure if converting theunspecified andunknown sentinels to become enum members is entirely worth it; now thatdefault is typed asobject anywhere, the benefits aren't so obvious. I do think it still makes the code alittle cleaner, but you tell me whether you think it's worth the churn@erlend-aasland :)

IMO, the more readable we can get clinic.py, the better. We should thread a little careful here, sincetest_clinic has pretty low coverage. Some of the paths modified are not tested. However, the CI doesmake clinic (for the check-generated-files job), and that would blow up if semantics changed for the code in question, so we're fine for now.

IMO, the more readable we can get clinic.py, the better. We should thread a little careful here, sincetest_clinic has pretty low coverage. Some of the paths modified are not tested. However, the CI doesmake clinic (for the check-generated-files job), and that would blow up if semantics changed for the code in question, so we're fine for now.

Fab. Thanks for the review!