Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-89091: raiseRuntimeWarning for unawaited async generator methods#104611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kumaraditya303 merged 5 commits intopython:mainfromkumaraditya303:agen
May 26, 2023

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303kumaraditya303 commentedMay 18, 2023
edited by bedevere-bot
Loading

graingert reacted with heart emoji
@markshannon
Copy link
Member

Adding finalization to objects created for everyasync for loop is likely to have an adverse effect on performance.
Have you benchmarked this?

@kumaraditya303
Copy link
ContributorAuthor

Runninghttps://github.com/python/pyperformance/blob/main/pyperformance/data-files/benchmarks/bm_async_generators/run_benchmark.py showsBenchmark hidden because not significant (1): async_generators. My benchmarking setup isn't very accurate though.

Copy link
Member

@gvanrossumgvanrossum left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. See my analysis inGH-89091.

@kumaraditya303
Copy link
ContributorAuthor

kumaraditya303 commentedMay 26, 2023
edited
Loading

I plan to land this later today if there are no further concerns.

@kumaraditya303kumaraditya303 added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelMay 26, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@kumaraditya303 for commit5e21e60 🤖

If you want to schedule another build, you need to add the🔨 test-with-buildbots label again.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes

@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

3.13bugs and security fixesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303@markshannon@bedevere-bot@gvanrossum

[8]ページ先頭

©2009-2025 Movatter.jp