NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.3k

gh-104523: inline minimal PGO rules#104524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

erlend-aasland merged 1 commit intopython:mainfromindygreg:build-pgo-rules-inline

May 16, 2023

Merged

gh-104523: inline minimal PGO rules#104524

erlend-aasland merged 1 commit intopython:mainfromindygreg:build-pgo-rules-inline

May 16, 2023

Conversation

Copy link

Contributor

indygreg commentedMay 16, 2023•
edited by bedevere-bot
Loading

Various rules were only ever invoked once and had minimal bodies. I don't see a benefit to the indirection.

So this commit inlines rules to simplify the PGO logic.

skip news

Issue:Overhaul build system rules related to profiling #104523

bedevere-bot added the awaiting review label

May 16, 2023

bedevere-bot mentioned this pull request

May 16, 2023

Overhaul build system rules related to profiling#104523

Open

pythongh-104523: inline minimal PGO rules

dd66e38

Various rules were only ever invoked once and had minimal bodies.I don't see a benefit to the indirection.So this commit inlines rules to simplify the PGO logic.skip news (trivial, non-user-visible change)

indygreg force-pushed thebuild-pgo-rules-inline branch from8eb0b50 todd66e38Compare

May 16, 2023 01:48

arhadthedev added the skip news label

May 16, 2023

erlend-aasland approved these changes

May 16, 2023

View reviewed changes

Copy link

Contributor

erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Makes sense. LGTM.

bedevere-bot added awaiting merge and removed awaiting review labels

May 16, 2023

Copy link

Contributor

erlend-aasland commentedMay 16, 2023

(Hypothesis failure is unrelated to this PR.)

erlend-aasland merged commit9084e1b intopython:main

May 16, 2023

bedevere-bot removed the awaiting merge label

May 16, 2023

carljm added a commit to carljm/cpython that referenced this pull request

May 16, 2023

Merge branch 'main' into supermon

a6dd626

* main:pythonGH-104510: Fix refleaks in `_io` base types (python#104516)pythongh-104539: Fix indentation error in logging.config.rst (python#104545)pythongh-104050: Don't star-import 'types' in Argument Clinic (python#104543)pythongh-104050: Add basic typing to CConverter in clinic.py (python#104538)pythongh-64595: Fix write file logic in Argument Clinic (python#104507)pythongh-104523: Inline minimal PGO rules (python#104524)pythongh-103861: Fix Zip64 extensions not being properly applied in some cases (python#103863)pythongh-69152: add method get_proxy_response_headers to HTTPConnection class (python#104248)pythongh-103763: Implement PEP 695 (python#103764)pythongh-104461: Run tkinter test_configure_screen on X11 only (pythonGH-104462)pythongh-104469: Convert _testcapi/watchers.c to use Argument Clinic (python#104503)pythongh-104482: Fix error handling bugs in ast.c (python#104483)pythongh-104341: Adjust tstate_must_exit() to Respect Interpreter Finalization (pythongh-104437)pythonGH-102613: Fix recursion error from `pathlib.Path.glob()` (pythonGH-104373)